Review main Merged

55488[BUGFIX] Invalid session token on creating content element in admin panel

Oliver Hader CR +2 V +2 Easy +7 −5 updated 01/29/18, 19:35

Commit message

When creating a new content element in the frontend using the according
button in the "editing" section of the admin panel, the request to the
TYPO3 backend is rejected due to an invalid XSRF session token:

	Validating the security token of this form has failed.
	Please reload the form and submit it again.

The reason is, that the URL after issue #70055 looks like the following
"token=<hash>id=<id>" instead of "token=<hash>&id=<id>" - the id became
part of the XSRF session token.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Alexander Opitz +1
  • Verified V +2
    • Oliver Hader +2
    • Alexander Opitz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Oliver Hader uploaded patch set 1 01/29/18, 15:34

  2. TYPO3com voted on patch set 1 V +1 01/29/18, 15:39 Completed build in 05m 47s on Mon, 29 Jan, 04:39 PM Test Summary: 30358 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18702

  3. Alexander Opitz voted on patch set 1 V +1 CR +1 01/29/18, 16:37

  4. Oliver Hader voted on patch set 1 V +2 CR +2 01/29/18, 19:35

  5. Oliver Hader merged patch set 2 01/29/18, 19:35