55500[BUGFIX] Avoid JS error when using 'eval' => 'int,nospace' in TCA
Commit message
Review
-
Code review CR +2
- Tymoteusz Motylewski +2
- Sascha Rademacher +1
- Oliver Klee +1
- Markus Klein +1
-
Verified V +2
- Tymoteusz Motylewski +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1618
-
Stephan Großberndt uploaded patch set 1 01/30/18, 11:30
-
TYPO3com voted on patch set 1 V +1 01/30/18, 11:35 Completed build in 05m 29s on Tue, 30 Jan, 12:35 PM Test Summary: 30355 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18724
-
Oliver Klee voted on patch set 1 CR +1 01/30/18, 11:48
-
Markus Klein commented on patch set 1 01/30/18, 11:51
-
Stephan Großberndt commented on patch set 1 CR -1 01/30/18, 11:53
FormEngineValidation.js:430ReplyThats right, should either be returnValue = ('' + value).replace(/ /g, ''); or returnValue = value.toString().replace(/ /g, ''); What do you prefer? -
Markus Klein commented on patch set 1 01/30/18, 11:59
FormEngineValidation.js:430Replyif toString() is available on all kinds of data types, that's the easiest thing to read. -
Stephan Großberndt commented on patch set 1 01/30/18, 12:06
var j = null; j.toString().replace(/ /g, ''); leads to JS error "TypeError: j is null" ('' + j).replace(/ /g, ''); returns the string "null" -
Stephan Großberndt commented on patch set 1 01/30/18, 12:06
-
Steffen Frese voted on patch set 1 CR +1 01/30/18, 12:39
-
Stephan Großberndt commented on patch set 1 01/30/18, 12:43
So if we want to avoid the JS error ('' + j).replace(/ /g, ''); would be better. I'll update accordingly. -
Stephan Großberndt uploaded patch set 2 01/30/18, 12:44
-
TYPO3com voted on patch set 2 V +1 01/30/18, 12:52 Completed build in 07m 47s on Tue, 30 Jan, 01:52 PM Test Summary: 30354 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18727
-
Sascha Rademacher voted on patch set 2 CR +1 01/30/18, 12:52
-
Oliver Klee voted on patch set 2 CR +1 01/30/18, 13:04
-
Markus Klein voted on patch set 2 V +1 CR +1 01/30/18, 14:40
-
Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 01/30/18, 14:43
-
Tymoteusz Motylewski merged patch set 3 01/30/18, 14:43
-
Tymoteusz Motylewski commented on patch set 3 01/30/18, 14:53
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 88dde215dda57f0f29b1a4277f879777adc0b1e0
FormEngineValidation.js:430