Review TYPO3_8-7 Merged

55503[BUGFIX] Avoid JS error when using 'eval' => 'int,nospace' in TCA

Tymoteusz Motylewski CR +2 V +2 Easy +1 −1 updated 01/30/18, 15:10

Commit message

By casting the JavaScript variable to string this patch avoids an error
if 'eval' => 'int,nospace' is used in a TCA column definition.

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
  • Verified V +2
    • Tymoteusz Motylewski +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Tymoteusz Motylewski commented on patch set 1 01/30/18, 14:53

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 01/30/18, 15:06 Completed build in 13m 08s on Tue, 30 Jan, 04:06 PM Test Summary: 57881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1708

  3. Tymoteusz Motylewski voted on patch set 1 V +2 CR +2 01/30/18, 15:10

  4. Tymoteusz Motylewski merged patch set 2 01/30/18, 15:10