Review main Merged

55511[BUGFIX] Access parent element in Element Browser correctly

Andreas Kienast CR +2 V +2 Easy +12 −8 updated 02/04/18, 17:43

Commit message

When the element browser is opened in a popup window, the parent element
(=popup) is now accessed properly.

This patch also fixes the case for `list_frame` which didn't work in
Firefox.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1220

  1. Andreas Kienast uploaded patch set 1 01/31/18, 15:01

  2. TYPO3com voted on patch set 1 V +1 01/31/18, 15:06 Completed build in 05m 23s on Wed, 31 Jan, 04:06 PM Test Summary: 30354 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18761

  3. Andreas Kienast commented on patch set 1 V -1 01/31/18, 15:09

    Breaks with Firefox...
  4. Andreas Kienast uploaded patch set 2 01/31/18, 15:28

  5. Andreas Kienast uploaded patch set 3 01/31/18, 15:28

  6. TYPO3com voted on patch set 2 V -1 01/31/18, 15:40 Completed build in 12m 13s on Wed, 31 Jan, 04:40 PM Test Summary: 30347 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18762

  7. TYPO3com voted on patch set 3 V -1 01/31/18, 15:41 Completed build in 12m 23s on Wed, 31 Jan, 04:41 PM Test Summary: 30347 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18763

  8. Andreas Kienast uploaded patch set 4 02/01/18, 08:38

  9. TYPO3com voted on patch set 4 V -1 02/01/18, 08:50 Completed build in 11m 30s on Thu, 1 Feb, 09:50 AM Test Summary: 30347 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18773

  10. Andreas Kienast uploaded patch set 5 02/01/18, 09:01

  11. TYPO3com voted on patch set 5 V -1 02/01/18, 09:12 Completed build in 11m 30s on Thu, 1 Feb, 10:12 AM Test Summary: 30347 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18774

  12. Andreas Kienast uploaded patch set 6 02/04/18, 16:56

  13. Andreas Kienast uploaded patch set 7 02/04/18, 17:03

  14. TYPO3com voted on patch set 6 V +1 02/04/18, 17:04 Completed build in 08m 12s on Sun, 4 Feb, 06:04 PM Test Summary: 30369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18888

  15. TYPO3com voted on patch set 7 V +1 02/04/18, 17:10 Completed build in 05m 59s on Sun, 4 Feb, 06:10 PM Test Summary: 30369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18889

  16. Andreas Kienast uploaded patch set 8 02/04/18, 17:21

  17. TYPO3com voted on patch set 8 V +1 02/04/18, 17:30 Completed build in 08m 59s on Sun, 4 Feb, 06:30 PM Test Summary: 30369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18891

  18. Mathias Schreiber voted on patch set 8 V +1 CR +1 02/04/18, 17:42

  19. Christian Kuhn voted on patch set 8 V +2 CR +2 02/04/18, 17:43

  20. Christian Kuhn merged patch set 9 02/04/18, 17:43