55533[BUGFIX] Fix timestamp handling in QueryGenerator
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Stefan Neufeind +1
- Sascha Rademacher +1
- Tobi Kretschmann +1
- Frank Nägler +1
-
Verified V +2
- Andreas Kienast +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2836
Show 811 earlier messages
-
Reiner Teubner uploaded patch set 1 02/02/18, 14:06
-
TYPO3com voted on patch set 1 V +1 02/02/18, 14:16 Completed build in 10m 02s on Fri, 2 Feb, 03:16 PM Test Summary: 30369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18821
-
Reiner Teubner updated the commit message in patch set 2 02/03/18, 22:04
-
TYPO3com voted on patch set 2 V +1 02/03/18, 22:13 Completed build in 08m 04s on Sat, 3 Feb, 11:13 PM Test Summary: 30387 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18858
-
Oliver Klee updated the commit message in patch set 3 02/04/18, 08:26
-
TYPO3com voted on patch set 3 V +1 02/04/18, 08:35 Completed build in 08m 15s on Sun, 4 Feb, 09:35 AM Test Summary: 30369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18867
-
Mathias Schreiber voted on patch set 3 V +1 CR +1 02/04/18, 09:09
-
Timo Pfeffer voted on patch set 3 CR +1 02/04/18, 15:48
-
Wouter Wolters voted on patch set 3 CR +1 02/04/18, 19:41
-
Jörg Bösche voted on patch set 3 CR +1 02/05/18, 08:12
-
Tobi Kretschmann voted on patch set 3 CR +1 02/05/18, 10:26
-
Reiner Teubner uploaded patch set 4 02/05/18, 22:25
-
TYPO3com voted on patch set 4 V -1 02/05/18, 22:25 Completed build in 10s on Mon, 5 Feb, 11:25 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18992
-
Reiner Teubner uploaded patch set 5 02/05/18, 22:27
-
Reiner Teubner commented on patch set 5 02/05/18, 22:30
Now all timestamp fields get catcht. -
TYPO3com voted on patch set 5 V +1 02/05/18, 22:36 Completed build in 08m 33s on Mon, 5 Feb, 11:36 PM Test Summary: 30416 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18993
-
Reiner Teubner uploaded patch set 6 02/05/18, 22:43
-
TYPO3com voted on patch set 6 V +1 02/05/18, 22:51 Completed build in 07m 49s on Mon, 5 Feb, 11:51 PM Test Summary: 30416 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18994
-
Reiner Teubner uploaded patch set 7 02/09/18, 12:56
-
TYPO3com voted on patch set 7 V +1 02/09/18, 13:05 Completed build in 08m 54s on Fri, 9 Feb, 02:05 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19184
-
Tobi Kretschmann voted on patch set 7 CR +1 02/09/18, 13:08
-
Stefan Neufeind commented on patch set 7 V +1 02/10/18, 19:12
tried with "greater than" (inputValue) and "between" (inputValue/inputValue1) - also with multiple date-comparisons in one queryQueryGenerator.php:1364correct that this has $suffix as well? -
Reiner Teubner commented on patch set 7 02/12/18, 23:15
QueryGenerator.php:1364ReplyYes, when you choose 'is between' the second value is saved as inputValue1. -
Reiner Teubner commented on patch set 7 02/12/18, 23:29
QueryGenerator.php:1364ReplyThe compare above should with $suffix as well but it works without it because there is no possible option to compare date fields with other fields. -
Frank Nägler commented on patch set 7 CR -1 02/13/18, 19:56
QueryGenerator.php:1684please use htmlspecialcharrs for $timstamp -
Reiner Teubner uploaded patch set 8 02/13/18, 21:10
-
Reiner Teubner commented on patch set 8 02/13/18, 21:11
QueryGenerator.php:1684ReplyDone -
Tobi Kretschmann voted on patch set 8 CR +1 02/13/18, 21:13
-
TYPO3com voted on patch set 8 V +1 02/13/18, 21:19 Completed build in 08m 37s on Tue, 13 Feb, 10:19 PM Test Summary: 30531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19524
-
Sascha Rademacher voted on patch set 8 CR +1 02/19/18, 10:09
-
Stefan Neufeind commented on patch set 8 CR +1 02/19/18, 10:33
couldn't verify it right now since my local BE-javascript seems broken somehow currently :-( -
Frank Nägler voted on patch set 8 CR +1 02/23/18, 14:01
-
Frank Nägler voted on patch set 8 V +1 02/23/18, 14:04
-
Andreas Kienast voted on patch set 8 V +2 CR +2 02/23/18, 14:34
-
Andreas Kienast merged patch set 9 02/23/18, 14:34
-
Andreas Kienast commented on patch set 9 02/23/18, 14:34
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit a49e66c38fd9c13aceb02b9307e207d3db3e9986