Review main Merged

55536[BUGFIX] Element Browser should only render default language pages

Benni Mack CR +2 V +2 Easy +1 −1 updated 02/03/18, 20:14

Commit message

The Browseable Trees (Element Browser) show pages with
language > 0 (page translations), due to a missing fix
during the pages_language_overlay refactoring.

The patch adds the restriction on deleted pages
and sys_language_uid=0 pages, just like PageTreeView
and the new page tree do it.

Review

  • Code review CR +2
    • Susi Moog +2
    • Mathias Schreiber +1
    • Michael Oehlhof +1
  • Verified V +2
    • Susi Moog +2
    • Mathias Schreiber +1
    • Riccardo De Contardi +1
    • Michael Oehlhof +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Benni Mack uploaded patch set 1 02/03/18, 19:59

  2. Susi Moog voted on patch set 1 CR +1 02/03/18, 20:02

  3. Mathias Schreiber voted on patch set 1 V +1 CR +1 02/03/18, 20:02

  4. TYPO3com voted on patch set 1 V +1 02/03/18, 20:07 Completed build in 07m 47s on Sat, 3 Feb, 09:07 PM Test Summary: 30369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18843

  5. Riccardo De Contardi commented on patch set 1 V +1 02/03/18, 20:10

    tested with both header_link and image link
  6. Susi Moog voted on patch set 1 V +2 CR +2 02/03/18, 20:11

  7. Susi Moog merged patch set 2 02/03/18, 20:11

  8. Michael Oehlhof voted on patch set 2 V +1 CR +1 02/03/18, 20:14