Review main Merged

55548[BUGFIX] Prevent enforcing opened database connection with initCommands

Nicole Hummel CR +2 V +2 Normal +62 −7 updated 02/04/18, 22:10

Commit message

This patch moves the execution of configured initCommands to the end
of connect function. This prevents a database connection from being
opened by default due to the execution of commands right after class
initialization and still ensures a connection is configured properly
before first command execution.

Furthermore this patch adds a new functional test for the ErrorHandler.
The test uses some predefined initCommands to enforce the strict mode
of MySQL database to be set. Due to the predefined initCommands the
test failed before as the connection was forced to be opened. For
further information see the referenced forge ticket.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Mathias Schreiber +1
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Helmut Hummel +2
    • Mathias Schreiber +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1522

  1. Nicole Hummel uploaded patch set 1 02/04/18, 11:20

  2. TYPO3com voted on patch set 1 V -1 02/04/18, 11:20 Completed build in 08s on Sun, 4 Feb, 12:20 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18870

  3. Nicole Hummel uploaded patch set 2 02/04/18, 11:21

  4. TYPO3com voted on patch set 2 V +1 02/04/18, 11:30 Completed build in 08m 28s on Sun, 4 Feb, 12:30 PM Test Summary: 30371 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18871

  5. Nicole Hummel uploaded patch set 3 02/04/18, 12:35

  6. TYPO3com voted on patch set 3 V -1 02/04/18, 12:43 Completed build in 08m 25s on Sun, 4 Feb, 01:43 PM Test Summary: 2 of 30526 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18873

  7. Nicole Hummel uploaded patch set 4 02/04/18, 12:46

  8. TYPO3com voted on patch set 4 V +1 02/04/18, 12:54 Completed build in 08m 09s on Sun, 4 Feb, 01:54 PM Test Summary: 30371 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18874

  9. Nicole Hummel updated the commit message in patch set 5 02/04/18, 13:12

  10. Nicole Hummel updated the commit message in patch set 6 02/04/18, 13:13

  11. Mathias Schreiber commented on patch set 6 CR +1 02/04/18, 13:22

    I do understand what the patch does. Any pointers how to verify other than your testcase?
  12. TYPO3com voted on patch set 5 V +1 02/04/18, 13:22 Completed build in 09m 25s on Sun, 4 Feb, 02:22 PM Test Summary: 30371 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18876

  13. TYPO3com voted on patch set 6 V +1 02/04/18, 13:22 Completed build in 09m 16s on Sun, 4 Feb, 02:22 PM Test Summary: 30371 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18877

  14. Helmut Hummel voted on patch set 6 CR +1 02/04/18, 13:48

  15. Nicole Hummel commented on patch set 6 CR -1 02/04/18, 14:02

    I will add some more information about the added functional test to the commit message
  16. Nicole Hummel updated the commit message in patch set 7 02/04/18, 15:01

  17. TYPO3com voted on patch set 7 V +1 02/04/18, 15:07 Completed build in 06m 09s on Sun, 4 Feb, 04:07 PM Test Summary: 30371 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18882

  18. Mathias Schreiber voted on patch set 7 V +1 CR +1 02/04/18, 15:30

  19. Christian Kuhn voted on patch set 7 V +1 CR +1 02/04/18, 18:14

  20. Wouter Wolters voted on patch set 7 CR +1 02/04/18, 19:40

  21. Helmut Hummel voted on patch set 7 V +2 CR +2 02/04/18, 22:10

  22. Helmut Hummel merged patch set 8 02/04/18, 22:10