Review TYPO3_8-7 Merged

55558[BUGFIX] Prevent enforcing opened database connection with initCommands

Helmut Hummel CR +2 V +2 Normal +70 −11 updated 02/06/18, 10:01

Commit message

This patch moves the execution of configured initCommands to the end
of connect function. This prevents a database connection from being
opened by default due to the execution of commands right after class
initialization and still ensures a connection is configured properly
before first command execution.

Furthermore this patch adds a new functional test for the ErrorHandler.
The test uses some predefined initCommands to enforce UTF8 support to be
set. This isn't necessary but uses initCommands in a safe way. Due to
the predefined initCommands the test failed before as the connection was
forced to be opened. For further information see the referenced forge
ticket.

Review

  • Code review CR +2
    • Nicole Hummel +2
  • Verified V +2
    • Nicole Hummel +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 610

  1. Helmut Hummel uploaded patch set 1 02/04/18, 22:19

  2. TYPO3com voted on patch set 1 V -1 02/04/18, 22:28 Completed build in 09m 44s on Sun, 4 Feb, 11:28 PM Test Summary: 2 of 58257 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1733

  3. Nicole Hummel uploaded patch set 2 02/05/18, 11:17

  4. TYPO3com voted on patch set 2 V -1 02/05/18, 11:26 Completed build in 09m 22s on Mon, 5 Feb, 12:26 PM Test Summary: 2 of 58257 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1744

  5. Nicole Hummel uploaded patch set 3 02/05/18, 11:29

  6. TYPO3com voted on patch set 3 V -1 02/05/18, 11:40 Completed build in 11m 34s on Mon, 5 Feb, 12:40 PM Test Summary: 1 of 58257 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1746

  7. Nicole Hummel uploaded patch set 4 02/05/18, 11:42

  8. TYPO3com voted on patch set 4 V +1 02/05/18, 11:51 Completed build in 08m 33s on Mon, 5 Feb, 12:51 PM Test Summary: 57913 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1748

  9. Nicole Hummel voted on patch set 4 V +2 CR +2 02/06/18, 10:01

  10. Nicole Hummel merged patch set 5 02/06/18, 10:01