55568[BUGFIX] Show active state for SelectIcons
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Mathias Schreiber +1
-
Verified V +2
- Frank Nägler +2
- Mathias Schreiber +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1421
-
Georg Ringer uploaded patch set 1 02/06/18, 02:45
-
TYPO3com voted on patch set 1 V +1 02/06/18, 02:51 Completed build in 05m 45s on Tue, 6 Feb, 03:51 AM Test Summary: 30416 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-18995
-
Christian Kuhn commented on patch set 1 02/06/18, 09:34
SelectIcons.php:50add a key with boolean value '"active" = true/false' here (or "selected" or similar. Do not use $parameterArray['itemFormElValue'] for active check, but access $this->data['database'] of according field name directly, expect the field value to be an array (see TcaSelectItems which prepares & sanitizes this value), expect that multiple items can be selected. -
Mathias Schreiber uploaded patch set 2 02/09/18, 19:03
-
Mathias Schreiber uploaded patch set 3 02/09/18, 19:07
-
TYPO3com voted on patch set 2 V -1 02/09/18, 19:11 Completed build in 07m 54s on Fri, 9 Feb, 08:11 PM Test Summary: 2 of 30625 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19210
-
TYPO3com voted on patch set 2 V +1 02/09/18, 19:15 Completed build in 19m 24s on Fri, 9 Feb, 08:15 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19210
-
TYPO3com voted on patch set 3 V +1 02/09/18, 19:15 Completed build in 08m 01s on Fri, 9 Feb, 08:15 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19211
-
Andreas Kienast commented on patch set 3 V -1 02/09/18, 20:56
Clicking slightly next to the icon, the active status vanishes. Will take a look -
Anja Leichsenring voted on patch set 3 V +1 CR +1 02/09/18, 21:05
-
Andreas Kienast uploaded patch set 4 02/09/18, 21:07
-
Andreas Kienast voted on patch set 4 V +1 CR +1 02/09/18, 21:10
-
TYPO3com voted on patch set 4 V -1 02/09/18, 21:15 Completed build in 07m 31s on Fri, 9 Feb, 10:15 PM Test Summary: 1 of 30625 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19235
-
TYPO3com voted on patch set 4 V +1 02/09/18, 21:22 Completed build in 22m 20s on Fri, 9 Feb, 10:22 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19235
-
Mathias Schreiber voted on patch set 4 V +1 CR +1 02/09/18, 21:26
-
Frank Nägler commented on patch set 4 V -1 02/09/18, 21:52
EXT:styleguide example select_single_7 is broken, in this example in some cases two icons are marked as active. -
Andreas Kienast uploaded patch set 5 02/09/18, 22:02
-
TYPO3com voted on patch set 5 V +1 02/09/18, 22:15 Completed build in 12m 28s on Fri, 9 Feb, 11:15 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19245
-
Mathias Schreiber voted on patch set 5 V +1 CR +1 02/09/18, 22:30
-
Frank Nägler voted on patch set 5 V +2 CR +2 02/09/18, 23:03
-
Frank Nägler merged patch set 6 02/09/18, 23:03
SelectIcons.php:23