Review TYPO3_8-7 Merged

55569[BUGFIX] Replace calls to the deprecated PHP function each()

Christian Kuhn CR +2 V +2 Normal +131 −7 updated 02/06/18, 10:32

Commit message

This patch replaces the calls to the PHP function each() as it is
marked as deprecated in PHP 7.2. Additionally it adds unit tests for
QueryGenerator::getSubscript().

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Hader +1
  • Verified V +2
    • Christian Kuhn +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 56

  1. Christian Kuhn commented on patch set 1 02/06/18, 10:18

    Cherry Picked from branch master.
  2. Christian Kuhn commented on patch set 1 02/06/18, 10:19

    Cherry Picked This patchset was cherry picked to branch TYPO3_7-6 as commit 1c76caf04eeb74cd43d4e1c63ea96909c1b99155
  3. TYPO3com voted on patch set 1 V +1 02/06/18, 10:30 Completed build in 11m 18s on Tue, 6 Feb, 11:30 AM Test Summary: 58015 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1771

  4. Oliver Hader voted on patch set 1 V +1 CR +1 02/06/18, 10:32

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 02/06/18, 10:32

  6. Christian Kuhn merged patch set 2 02/06/18, 10:32