Review TYPO3_7-6 Merged

55570[BUGFIX] Replace calls to the deprecated PHP function each()

Christian Kuhn CR +2 V +2 Normal +130 −7 updated 02/06/18, 10:43

Commit message

This patch replaces the calls to the PHP function each() as it is
marked as deprecated in PHP 7.2. Additionally it adds unit tests for
QueryGenerator::getSubscript().

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Oliver Hader +1
  • Verified V +2
    • Christian Kuhn +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 912

  1. Christian Kuhn commented on patch set 1 02/06/18, 10:19

    Cherry Picked from branch TYPO3_8-7.
  2. TYPO3com voted on patch set 1 V -1 02/06/18, 10:26 Completed build in 06m 53s on Tue, 6 Feb, 11:26 AM Test Summary: 4720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1343

  3. Oliver Hader commented on patch set 1 02/06/18, 10:29

    QueryGeneratorTest.php:2

    PHP 5.5

    QueryGeneratorTest.php:19

    different base class for TYPO3 v7
  4. Oliver Hader commented on patch set 2 02/06/18, 10:31

    Published edit on patch set 1.
  5. Christian Kuhn rebased onto patch set 3 02/06/18, 10:31

  6. Christian Kuhn commented on patch set 3 02/06/18, 10:32

    lol ol. just did exactly the same ;)
  7. TYPO3com voted on patch set 2 V +1 02/06/18, 10:36 Completed build in 05m 24s on Tue, 6 Feb, 11:36 AM Test Summary: 49124 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1344

  8. Oliver Hader voted on patch set 3 V +1 CR +1 02/06/18, 10:37

  9. Christian Kuhn commented on patch set 3 V +1 CR +1 02/06/18, 10:39

    waiting for bamboo +1
  10. TYPO3com voted on patch set 3 V +1 02/06/18, 10:42 Completed build in 10m 40s on Tue, 6 Feb, 11:42 AM Test Summary: 49124 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC76-1345

  11. Christian Kuhn voted on patch set 3 V +2 CR +2 02/06/18, 10:43

  12. Christian Kuhn merged patch set 4 02/06/18, 10:43