55603[WIP][TASK] Upgrade SwiftMailer to v6
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 14
- typo3/sysext/core/Classes/Mail/Compatibility/MailTransport.php1new+305 −0
- typo3/sysext/core/Classes/Mail/MboxTransport.php+13 −5
- typo3/sysext/core/Classes/Mail/TransportFactory.php+6 −4
- typo3/sysext/core/Migrations/Code/ClassAliasMap.php1+2 −0
- typo3/sysext/core/Tests/Unit/Mail/Fixtures/FakeInvalidSpoolFixture.php+1 −1
- typo3/sysext/core/Tests/Unit/Mail/Fixtures/FakeValidSpoolFixture.php+1 −1
- typo3/sysext/core/Tests/Unit/Mail/MailerTest.php+0 −32
- typo3/sysext/core/Tests/Unit/Mail/TransportFactoryTest.php+0 −23
- typo3/sysext/core/Tests/UnitDeprecated/Mail/MailerTest.phpnew+73 −0
- typo3/sysext/core/Tests/UnitDeprecated/Mail/TransportFactoryTest.phpnew+65 −0
- typo3/sysext/core/composer.json+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php+1 −1
- composer.json+1 −1
- composer.lock+68 −10
Review log 2130
Show 45 earlier messages
-
Stefan Neufeind uploaded patch set 1 02/08/18, 08:52
-
Stefan Neufeind commented on patch set 1 02/08/18, 08:54
How do we want to handle the dropped mail-transport? They write it's for security-reasons (https://github.com/swiftmailer/swiftmailer/issues/866). And even in 8 LTS we use a SwiftMailer where they at least deprecated the mail-transport already. I guess that calls for a breaking-RST? How do we handle upgrades from previous versions, since there isn't really an alternative we can upgrade to? -
Stefan Neufeind commented on patch set 1 02/08/18, 08:58
Dropped mail-transport calls for changes in: typo3/sysext/core/Configuration/DefaultConfiguration.php typo3/sysext/install/Resources/Private/Partials/Environment/MailTest.html typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml typo3/sysext/core/Classes/Mail/Mailer.php -
TYPO3com voted on patch set 1 V +1 02/08/18, 09:01 Completed build in 08m 43s on Thu, 8 Feb, 10:01 AM Test Summary: 30461 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19127
-
Mathias Brodala commented on patch set 1 02/08/18, 09:34
> How do we want to handle the dropped mail-transport? They write > it's for security-reasons (https://github.com/swiftmailer/swiftmailer/issues/866). > And even in 8 LTS we use a SwiftMailer where they at least > deprecated the mail-transport already. > I guess that calls for a breaking-RST? How do we handle upgrades > from previous versions, since there isn't really an alternative we > can upgrade to? I guess we could make an exception here and add a deprecation warning in v8 for usage of the "mail" transport. This way at least some people will notice and can take action. As for upgrades we could detect if still "mail" is used and show a warning/error in the Install Too. For usage at runtime I don't see anything else besides a hard exception. If we don't do it, Swift Mailer will. In any case the "mail" transport is not usable at this point.
-
Benni Mack commented on patch set 1 02/10/18, 23:45
that's a breaking change. either we can shim the old classes in this change (with our ClassAliasMap) and find out all breaking changes, or we just wait until v10 (then we should abandon this patch and put it on our list for v10.0) -
Stefan Neufeind commented on patch set 1 02/12/18, 08:49
As suggested by Benni I'd raise discussion on this in the core-team-channel ... stay tuned. -
Benni Mack uploaded patch set 2 05/10/18, 14:52
-
TYPO3com voted on patch set 2 V -1 05/10/18, 14:52 Completed build in 05s on Thu, 10 May, 04:52 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23272
-
Benni Mack uploaded patch set 3 05/10/18, 14:57
-
Benni Mack commented on patch set 3 05/10/18, 14:57
Stefan, can you please take over to finish this one now? -
TYPO3com voted on patch set 3 V -1 05/10/18, 15:04 Completed build in 07m 31s on Thu, 10 May, 05:04 PM Test Summary: 2917 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23273
-
Stefan Neufeind uploaded patch set 4 05/13/18, 17:52
-
TYPO3com voted on patch set 4 V -1 05/13/18, 18:01 Completed build in 09m 41s on Sun, 13 May, 08:01 PM Test Summary: 2917 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23445
-
Stefan Neufeind uploaded patch set 5 05/13/18, 18:32
-
TYPO3com voted on patch set 5 V -1 05/13/18, 18:40 Completed build in 08m 29s on Sun, 13 May, 08:40 PM Test Summary: 9 of 31400 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23448
-
Stefan Neufeind uploaded patch set 6 05/14/18, 06:20
-
TYPO3com voted on patch set 6 V -1 05/14/18, 06:20 Completed build in 06s on Mon, 14 May, 08:20 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23463
-
Stefan Neufeind uploaded patch set 7 05/14/18, 06:22
-
TYPO3com voted on patch set 7 V -1 05/14/18, 06:31 Completed build in 08m 44s on Mon, 14 May, 08:31 AM Test Summary: 6 of 31425 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23464
-
Georg Ringer commented on patch set 7 05/14/18, 06:34
reading https://github.com/swiftmailer/swiftmailer/blob/master/CHANGES this must also include a breaking RST and a feature rst and is for sure no TASK ;) -
Stefan Neufeind uploaded patch set 8 05/14/18, 06:36
-
TYPO3com voted on patch set 8 V -1 05/14/18, 06:44 Completed build in 07m 39s on Mon, 14 May, 08:44 AM Test Summary: 31174 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23465
-
Stefan Neufeind uploaded patch set 9 05/14/18, 08:04
-
TYPO3com voted on patch set 9 V +1 05/14/18, 08:12 Completed build in 08m 04s on Mon, 14 May, 10:12 AM Test Summary: 31174 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23467
-
Mathias Brodala commented on patch set 9 05/14/18, 08:38
MailTransport.php:28This should be updated to TYPO3. -
Oliver Klee commented on patch set 9 05/19/18, 11:33
ClassAliasMap.php:3Should we also have the old classes extending the new and marked @deprecated so IDEs show that the new classes should be used? -
Georg Ringer commented on patch set 9 CR -1 05/21/18, 17:56
this is a breaking change and the rst should contain also a list of breaing changes in swiftmailer -
Benni Mack commented on patch set 9 10/26/18, 13:57
this patch did not make it into v9, and SwiftMailer will be integrated into Symfony as Mailer component, so I'd opt for dropping this change completely. -
Stefan Neufeind abandoned the change 10/26/18, 14:39
abandoned for v9, switching to Symfony for master soon