Review TYPO3_8-7 Merged

55609[TASK] Improve file overwriting dialog of the filelist module

Susi Moog CR +2 V +2 Easy +19 −3 updated 02/08/18, 19:05

Commit message

- Remove grey background box
- Move buttons on the same row
- Better position for alternatively actions
- Some margins for better positions

Review

  • Code review CR +2
    • Susi Moog +2
    • Anja Leichsenring +1
  • Verified V +2
    • Susi Moog +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 46

  1. Susi Moog uploaded patch set 1 02/08/18, 18:33

  2. Anja Leichsenring voted on patch set 1 V +1 CR +1 02/08/18, 18:41

  3. TYPO3com voted on patch set 1 V -1 02/08/18, 18:44 Completed build in 10m 51s on Thu, 8 Feb, 07:44 PM Test Summary: 2 of 58371 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1782

  4. TYPO3com voted on patch set 1 V +1 02/08/18, 18:56 Completed build in 33m 29s on Thu, 8 Feb, 07:56 PM Test Summary: 58027 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1782

  5. Susi Moog voted on patch set 1 V +2 CR +2 02/08/18, 19:05

  6. Susi Moog merged patch set 2 02/08/18, 19:05