Review main Merged

55615[BUGFIX] Align Storage “is_public” checkbox with checkbox styles

Mathias Schreiber CR +2 V +2 Easy +18 −8 updated 02/08/18, 22:45

Commit message

The markup generated by the UserStorageCapabilityService is now
in line with the overall styling of checkboxes in TCA.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 915

  1. Mathias Schreiber uploaded patch set 1 02/08/18, 19:27

  2. TYPO3com voted on patch set 1 V +1 02/08/18, 19:36 Completed build in 09m 16s on Thu, 8 Feb, 08:36 PM Test Summary: 30467 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19157

  3. Susi Moog commented on patch set 1 V -1 02/08/18, 19:56

    checkbox can't be checked :'(
  4. Mathias Schreiber uploaded patch set 2 02/08/18, 20:26

  5. TYPO3com voted on patch set 2 V -1 02/08/18, 20:34 Completed build in 07m 56s on Thu, 8 Feb, 09:34 PM Test Summary: 1 of 30622 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19167

  6. Mathias Schreiber uploaded patch set 3 02/08/18, 20:45

  7. TYPO3com voted on patch set 3 V -1 02/08/18, 20:45 Completed build in 08s on Thu, 8 Feb, 09:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19168

  8. Mathias Schreiber uploaded patch set 4 02/08/18, 20:46

  9. TYPO3com voted on patch set 4 V -1 02/08/18, 20:54 Completed build in 08m 00s on Thu, 8 Feb, 09:54 PM Test Summary: 1 of 30622 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19169

  10. TYPO3com commented on patch set 4 02/08/18, 21:04 Completed build in 25m 42s on Thu, 8 Feb, 10:04 PM Test Summary: 1 of 30622 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19169

  11. TYPO3com voted on patch set 4 V +1 02/08/18, 21:08 Completed build in 47m 53s on Thu, 8 Feb, 10:08 PM Test Summary: 30467 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19169

  12. Anja Leichsenring voted on patch set 4 V +1 CR +1 02/08/18, 21:10

  13. Riccardo De Contardi commented on patch set 4 V +1 02/08/18, 21:11

    seems to work
  14. Christian Kuhn voted on patch set 4 V +2 CR +2 02/08/18, 22:45

  15. Christian Kuhn merged patch set 5 02/08/18, 22:45