Review TYPO3_8-7 Merged

55623[TASK] Resolve Todos in InheritancesResolverService

Christian Kuhn CR +2 V +2 Normal +117 −69 updated 02/08/18, 23:15

Commit message

Add some comments to understand InheritanceResolverService class.
Minor refactoring of duplicated code.
Add Test for the doc example.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Christian Kuhn uploaded patch set 1 02/08/18, 23:06

  2. TYPO3com voted on patch set 1 V +1 02/08/18, 23:14 Completed build in 08m 05s on Fri, 9 Feb, 12:14 AM Test Summary: 58033 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1790

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 02/08/18, 23:15

  4. Christian Kuhn merged patch set 2 02/08/18, 23:15