Review main Merged

55628[BUGFIX] Add missing character in upgrade wizard SectionFrameToFrameClassUpdate

Patrick Lenk CR +2 V +2 Easy +1 −1 updated 02/09/18, 13:34

Commit message

Review

  • Code review CR +2
    • Andreas Kienast +2
  • Verified V +2
    • Andreas Kienast +2

Issues 1

Files 1

Review log 811

  1. Patrick Lenk uploaded patch set 1 02/09/18, 13:08

  2. TYPO3com voted on patch set 1 V +1 02/09/18, 13:16 Completed build in 07m 53s on Fri, 9 Feb, 02:16 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19187

  3. Mathias Schreiber voted on patch set 1 V +1 CR +1 02/09/18, 13:20

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 02/09/18, 13:22

  5. Mathias Schreiber updated the commit message in patch set 2 02/09/18, 13:22

  6. Mathias Schreiber updated the commit message in patch set 3 02/09/18, 13:22

  7. Andreas Kienast voted on patch set 3 V +2 CR +2 02/09/18, 13:23

  8. Andreas Kienast merged patch set 4 02/09/18, 13:23

  9. Riccardo De Contardi commented on patch set 4 02/09/18, 13:24

    SectionFrameToFrameClassUpdate.php:59

    the phrase is a bit hard to read. Maybe it is "[...]that will simply be passed to the rendering." ?
  10. TYPO3com voted on patch set 2 V +1 02/09/18, 13:32 Completed build in 09m 47s on Fri, 9 Feb, 02:32 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19189

  11. TYPO3com voted on patch set 3 V +1 02/09/18, 13:34 Completed build in 12m 03s on Fri, 9 Feb, 02:34 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19190