55629[BUGFIX] Cast values always to string before applying through ini_set
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Mathias Schreiber +1
- Oliver Klee +1
-
Verified V +2
- Christian Kuhn +2
- Mathias Schreiber +1
- TYPO3com +1 CI
Issues 1
Files 4
Review log 1217
-
Benjamin Kott uploaded patch set 1 02/09/18, 13:18
-
Mathias Schreiber voted on patch set 1 V +1 CR +1 02/09/18, 13:19
-
Benjamin Kott updated the commit message in patch set 2 02/09/18, 13:23
-
Benjamin Kott updated the commit message in patch set 3 02/09/18, 13:25
-
TYPO3com voted on patch set 1 V -1 02/09/18, 13:28 Completed build in 09m 54s on Fri, 9 Feb, 02:28 PM Test Summary: 1 of 30625 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19188
-
TYPO3com voted on patch set 2 V +1 02/09/18, 13:36 Completed build in 12m 35s on Fri, 9 Feb, 02:36 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19191
-
TYPO3com voted on patch set 3 V +1 02/09/18, 13:40 Completed build in 15m 46s on Fri, 9 Feb, 02:40 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19193
-
TYPO3com voted on patch set 1 V +1 02/09/18, 13:41 Completed build in 32m 46s on Fri, 9 Feb, 02:41 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19188
-
Andreas Kienast commented on patch set 3 02/09/18, 13:56
SessionService.php:79I'd use '100' here instead -
Mathias Schreiber commented on patch set 3 02/09/18, 13:59
SessionService.php:79Reply Unresolvedtechnically you're absolutely correct. I said the same, but came to the realization that if the write '100' some "pro" will try to optimize it later on -
Mathias Schreiber voted on patch set 3 V +1 CR +1 02/09/18, 14:07
-
Christian Kuhn uploaded patch set 4 02/09/18, 15:39
-
Christian Kuhn commented on patch set 4 V +2 CR +2 02/09/18, 15:40
sorry for cgl nitpicking (but hey, i pushed that fixed already): no whitespace after cast ... -
Mathias Schreiber voted on patch set 4 V +1 CR +1 02/09/18, 15:41
-
Oliver Klee voted on patch set 4 CR +1 02/09/18, 15:44
-
TYPO3com voted on patch set 4 V +1 02/09/18, 15:46 Completed build in 07m 00s on Fri, 9 Feb, 04:46 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19202
-
Christian Kuhn merged patch set 5 02/09/18, 15:55
Bootstrap.php:662Unresolved