Review main Merged

55629[BUGFIX] Cast values always to string before applying through ini_set

Benjamin Kott CR +2 V +2 Easy +9 −9 updated 02/09/18, 15:55

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Oliver Klee +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1217

  1. Benjamin Kott uploaded patch set 1 02/09/18, 13:18

  2. Mathias Schreiber voted on patch set 1 V +1 CR +1 02/09/18, 13:19

  3. Benjamin Kott updated the commit message in patch set 2 02/09/18, 13:23

  4. Benjamin Kott updated the commit message in patch set 3 02/09/18, 13:25

  5. TYPO3com voted on patch set 1 V -1 02/09/18, 13:28 Completed build in 09m 54s on Fri, 9 Feb, 02:28 PM Test Summary: 1 of 30625 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19188

  6. TYPO3com voted on patch set 2 V +1 02/09/18, 13:36 Completed build in 12m 35s on Fri, 9 Feb, 02:36 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19191

  7. TYPO3com voted on patch set 3 V +1 02/09/18, 13:40 Completed build in 15m 46s on Fri, 9 Feb, 02:40 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19193

  8. TYPO3com voted on patch set 1 V +1 02/09/18, 13:41 Completed build in 32m 46s on Fri, 9 Feb, 02:41 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19188

  9. Andreas Kienast commented on patch set 3 02/09/18, 13:56

    Bootstrap.php:662 Unresolved

    IMO we don't need the cast here as a string (m) is appended, which casts the whole expression to a string anyway

    SessionService.php:79

    I'd use '100' here instead
  10. Mathias Schreiber commented on patch set 3 02/09/18, 13:59

    SessionService.php:79 Reply Unresolved

    technically you're absolutely correct. I said the same, but came to the realization that if the write '100' some "pro" will try to optimize it later on
  11. Mathias Schreiber voted on patch set 3 V +1 CR +1 02/09/18, 14:07

  12. Christian Kuhn uploaded patch set 4 02/09/18, 15:39

  13. Christian Kuhn commented on patch set 4 V +2 CR +2 02/09/18, 15:40

    sorry for cgl nitpicking (but hey, i pushed that fixed already): no whitespace after cast ...
  14. Mathias Schreiber voted on patch set 4 V +1 CR +1 02/09/18, 15:41

  15. Oliver Klee voted on patch set 4 CR +1 02/09/18, 15:44

  16. TYPO3com voted on patch set 4 V +1 02/09/18, 15:46 Completed build in 07m 00s on Fri, 9 Feb, 04:46 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19202

  17. Christian Kuhn merged patch set 5 02/09/18, 15:55