Review main Merged

55630[BUGFIX] Fix typo in field description SYS:ddmmyy

Reiner Teubner CR +2 V +2 Easy +1 −1 updated 02/09/18, 18:31

Commit message

'Date' should be 'Day'.

Review

  • Code review CR +2
    • Stefan Neufeind +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2
    • Stefan Neufeind +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Reiner Teubner uploaded patch set 1 02/09/18, 13:36

  2. Anja Leichsenring voted on patch set 1 V +1 CR +1 02/09/18, 13:37

  3. TYPO3com voted on patch set 1 V +1 02/09/18, 13:44 Completed build in 08m 44s on Fri, 9 Feb, 02:44 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19194

  4. Mathias Brodala commented on patch set 1 02/09/18, 13:53

    DefaultConfigurationDescription.yaml:103

    How about "Default date format"? That's what this value is used for after all despite its non-descriptive name.
  5. Tymoteusz Motylewski commented on patch set 1 02/09/18, 14:30

    let's change the commit message to "imperative present tense"see https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/GitSetup/CommitMessageFormat.html e.g. "Fix typo in field description ..."
  6. Reiner Teubner updated the commit message in patch set 2 02/09/18, 14:37

  7. TYPO3com voted on patch set 2 V +1 02/09/18, 14:45 Completed build in 07m 54s on Fri, 9 Feb, 03:45 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19197

  8. Christian Kuhn updated the commit message in patch set 3 02/09/18, 15:09

  9. Christian Kuhn commented on patch set 3 V +1 CR +1 02/09/18, 15:10

    removed 7.6 from releases: not critical and i'm too lazy for the backport (different file format in v7)
  10. TYPO3com voted on patch set 3 V +1 02/09/18, 15:18 Completed build in 08m 58s on Fri, 9 Feb, 04:18 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19201

  11. Oliver Klee voted on patch set 3 CR +1 02/09/18, 15:19

  12. Stefan Neufeind voted on patch set 3 V +2 CR +2 02/09/18, 18:31

  13. Stefan Neufeind merged patch set 4 02/09/18, 18:31