Review main Merged

55638[BUGFIX] Set default values in TCA of sys_file_collection

Andreas Kienast CR +2 V +2 Easy +6 −3 updated 02/11/18, 12:46

Commit message

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1
    • Mathias Schreiber +1
    • Oliver Klee +1
    • Jörg Bösche +1
  • Verified V +2
    • Jigal van Hemert +2
    • Stefan Neufeind +1
    • Mathias Schreiber +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1521

  1. Andreas Kienast uploaded patch set 1 02/09/18, 21:19

  2. TYPO3com voted on patch set 1 V -1 02/09/18, 21:26 Completed build in 07m 11s on Fri, 9 Feb, 10:26 PM Test Summary: 2 of 30625 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19236

  3. Mathias Schreiber voted on patch set 1 V +1 CR +1 02/09/18, 21:26

  4. TYPO3com commented on patch set 1 02/09/18, 21:30 Completed build in 18m 39s on Fri, 9 Feb, 10:30 PM Test Summary: 2 of 30625 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19236

  5. TYPO3com commented on patch set 1 02/09/18, 21:37 Completed build in 36m 38s on Fri, 9 Feb, 10:37 PM Test Summary: 1 of 30625 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19236

  6. TYPO3com commented on patch set 1 02/09/18, 23:04 Completed build in 2h 21m 35s on Sat, 10 Feb, 12:04 AM Test Summary: 1 of 30625 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19236

  7. Andreas Kienast rebased onto patch set 2 02/09/18, 23:07

  8. TYPO3com voted on patch set 2 V +1 02/09/18, 23:16 Completed build in 09m 06s on Sat, 10 Feb, 12:16 AM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19250

  9. Georg Ringer voted on patch set 2 V +1 CR +1 02/10/18, 07:20

  10. Oliver Klee voted on patch set 2 CR +1 02/10/18, 10:36

  11. Wouter Wolters voted on patch set 2 CR +1 02/10/18, 11:14

  12. Mathias Schreiber voted on patch set 2 V +1 CR +1 02/10/18, 17:20

  13. Stefan Neufeind uploaded patch set 3 02/10/18, 18:00

  14. Stefan Neufeind commented on patch set 3 V +1 CR +1 02/10/18, 18:01

    trying it out I also needed a default-value for "storage" on a fresh/empty record
  15. TYPO3com voted on patch set 3 V +1 02/10/18, 18:08 Completed build in 07m 37s on Sat, 10 Feb, 07:08 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19300

  16. Mathias Schreiber voted on patch set 3 V +1 CR +1 02/10/18, 20:11

  17. Jörg Bösche voted on patch set 3 V +1 CR +1 02/10/18, 21:38

  18. Oliver Klee voted on patch set 3 CR +1 02/10/18, 21:42

  19. Jigal van Hemert voted on patch set 3 V +2 CR +2 02/11/18, 12:46

  20. Jigal van Hemert merged patch set 4 02/11/18, 12:46

  21. Jigal van Hemert commented on patch set 4 02/11/18, 12:46

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit d4d1322a0a36c7e79c48b4ef955dd518011e3431