Review main Merged

55659[TASK] Move info popups to modal windows

Benjamin Kott CR +2 V +2 Normal +127 −31 updated 02/12/18, 10:39

Commit message

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Jörg Bösche +1
  • Verified V +2
    • Andreas Kienast +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 23

Show 3 more files

Review log 914

  1. Benjamin Kott uploaded patch set 1 02/10/18, 22:05

  2. TYPO3com voted on patch set 1 V +1 02/10/18, 22:14 Completed build in 09m 29s on Sat, 10 Feb, 11:14 PM Test Summary: 30470 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19315

  3. Benni Mack voted on patch set 1 V +1 CR +1 02/11/18, 00:37

  4. Christian Kuhn commented on patch set 1 02/11/18, 13:52

    cool. thx for this one!
  5. Andreas Kienast commented on patch set 1 CR -1 02/11/18, 17:23

    On it
  6. Andreas Kienast commented on patch set 1 02/11/18, 17:58

    * 1 left over in FileList.js * ReST file for deprecation missing * New modules should be written in TypeScript first (already done)
  7. Andreas Kienast uploaded patch set 2 02/11/18, 18:31

  8. TYPO3com voted on patch set 2 V -1 02/11/18, 18:39 Completed build in 08m 01s on Sun, 11 Feb, 07:39 PM Test Summary: 2 of 30724 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19340

  9. TYPO3com commented on patch set 2 02/11/18, 19:04 Completed build in 41m 39s on Sun, 11 Feb, 08:04 PM Test Summary: 1 of 30724 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19340

  10. TYPO3com commented on patch set 2 02/11/18, 19:09 Completed build in 1h 20m 03s on Sun, 11 Feb, 08:09 PM Test Summary: 1 of 30724 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19340

  11. TYPO3com voted on patch set 2 V +1 02/11/18, 19:32 Completed build in 2h 21m 09s on Sun, 11 Feb, 08:32 PM Test Summary: 30569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19340

  12. Jörg Bösche voted on patch set 2 V +1 CR +1 02/12/18, 09:33

  13. Andreas Kienast voted on patch set 2 V +2 CR +2 02/12/18, 10:39

  14. Andreas Kienast merged patch set 3 02/12/18, 10:39