Review main Merged

55668[FEATURE] Add bcrypt and argon2i password hashes

Christian Futterlieb CR +2 V +2 Hard +925 −1 updated 05/22/18, 08:59

Commit message

Two new ext:saltedpasswords classes implement bcrypt
and argon2i password hashes.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 3750

Show 1725 earlier messages
  1. Christian Futterlieb uploaded patch set 1 02/11/18, 20:25

  2. TYPO3com voted on patch set 1 V -1 02/11/18, 20:25 Completed build in 11s on Sun, 11 Feb, 09:25 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19343

  3. Christian Futterlieb uploaded patch set 2 02/11/18, 20:32

  4. TYPO3com voted on patch set 2 V -1 02/11/18, 20:32 Completed build in 08s on Sun, 11 Feb, 09:32 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19344

  5. Christian Futterlieb uploaded patch set 3 02/11/18, 20:35

  6. TYPO3com voted on patch set 3 V +1 02/11/18, 20:43 Completed build in 08m 41s on Sun, 11 Feb, 09:43 PM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19345

  7. Tobi Kretschmann voted on patch set 3 CR +1 02/12/18, 10:09

  8. Steffen Frese voted on patch set 3 V +1 CR +1 02/13/18, 14:27

  9. Tobi Kretschmann voted on patch set 3 V +1 02/13/18, 14:41

  10. Jörg Bösche uploaded patch set 4 02/13/18, 14:41

  11. Oliver Klee commented on patch set 4 02/13/18, 14:44

    InvalidSaltException.php:2

    strict, please.
  12. Jörg Bösche uploaded patch set 5 02/13/18, 14:46

  13. TYPO3com voted on patch set 4 V +1 02/13/18, 14:52 Completed build in 08m 13s on Tue, 13 Feb, 03:52 PM Test Summary: 30864 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19494

  14. Tobi Kretschmann voted on patch set 5 V +1 CR +1 02/13/18, 14:52

  15. TYPO3com voted on patch set 5 V -1 02/13/18, 14:56 Completed build in 07m 49s on Tue, 13 Feb, 03:56 PM Test Summary: 1 of 31022 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19495

  16. Steffen Frese voted on patch set 5 V +1 CR +1 02/13/18, 15:05

  17. TYPO3com voted on patch set 5 V +1 02/13/18, 15:36 Completed build in 55m 28s on Tue, 13 Feb, 04:36 PM Test Summary: 30864 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19495

  18. Christian Futterlieb uploaded patch set 6 02/22/18, 13:51

  19. Mathias Schreiber voted on patch set 6 V +1 CR +1 02/22/18, 13:53

  20. TYPO3com voted on patch set 6 V +1 02/22/18, 14:01 Completed build in 09m 10s on Thu, 22 Feb, 03:01 PM Test Summary: 31214 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20023

  21. Christian Kuhn commented on patch set 6 CR -1 02/22/18, 14:35

    please give me a chance to get my hands dirty on this patch somewhere next days.
  22. Andreas Wolf commented on patch set 7 03/18/18, 09:18

    Published edit on patch set 6.
  23. Andreas Wolf uploaded patch set 8 03/18/18, 09:22

  24. Andreas Wolf uploaded patch set 9 03/18/18, 09:23

  25. TYPO3com voted on patch set 7 V +1 03/18/18, 09:31 Completed build in 12m 44s on Sun, 18 Mar, 10:31 AM Test Summary: 31215 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21600

  1. TYPO3com voted on patch set 8 V +1 03/18/18, 09:33 Completed build in 11m 15s on Sun, 18 Mar, 10:33 AM Test Summary: 31215 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21602

  2. TYPO3com voted on patch set 9 V +1 03/18/18, 09:35 Completed build in 11m 31s on Sun, 18 Mar, 10:35 AM Test Summary: 31215 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-21603

  3. Andreas Wolf voted on patch set 9 V +1 CR +1 03/18/18, 12:37

  4. Andreas Wolf wrote 03/18/18, 12:57

    Removed Code-Review+1 by Andreas Wolf <andreas.wolf@typo3.org>
  5. Andreas Wolf commented on patch set 9 CR -1 03/18/18, 13:00

    The parameters for argon2i (time/memory cost, threads) should be configurable.
  6. Christian Futterlieb commented on patch set 9 03/18/18, 15:22

    > The parameters for argon2i (time/memory cost, threads) should be configurable. They are, see setMemoryCost(), setTimeCost() and setThreads()
  7. Christian Kuhn commented on patch set 9 CR -1 03/29/18, 09:41

    working on it.
  8. Christian Kuhn commented on patch set 9 03/29/18, 10:52

    played around with numbers on argon2i: * raised memory_cost from default 1kb to 16kb (16*1024) * raised time_cost from default 2 to 16 * kept threads at 2 -> "decent" machines occupy 2 hardware cpu's for 80 to 160ms. that seems to be a sensible default and should be ok for machines that are a bit slower than that and still be good as default for a while.
  9. Christian Kuhn commented on patch set 9 03/29/18, 11:05

    for bcrypt, i'd go with 12 "cost" instead of default 10 to be around 150-250 ms (using a single cpu)
  10. Christian Kuhn commented on patch set 9 05/11/18, 11:37

    wah. sorry for this huge delay again. my bad. i'm finally working on it again, will push updates. i decided to simplify the code a bit: the easier and straighter this is implemented, the lower are risks for potentially fatal bugs. i thus decided to omit the abstract class and will streamline the two hash classes accordingly.
  11. Christian Kuhn uploaded patch set 10 05/11/18, 15:11

  12. Christian Kuhn voted on patch set 10 V +1 CR +1 05/11/18, 15:14

  13. Anja Leichsenring voted on patch set 10 V +1 CR +1 05/11/18, 15:16

  14. TYPO3com voted on patch set 10 V -1 05/11/18, 15:20 Completed build in 09m 18s on Fri, 11 May, 05:20 PM Test Summary: 31099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23330

  15. Mathias Schreiber voted on patch set 10 V +1 CR +1 05/11/18, 15:23

  16. Christian Kuhn uploaded patch set 11 05/11/18, 15:25

  17. Christian Kuhn voted on patch set 11 V +1 CR +1 05/11/18, 15:25

  18. TYPO3com voted on patch set 11 V -1 05/11/18, 15:33 Completed build in 07m 35s on Fri, 11 May, 05:33 PM Test Summary: 1 of 31347 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23333

  19. TYPO3com voted on patch set 11 V +1 05/11/18, 15:34 Completed build in 16m 44s on Fri, 11 May, 05:34 PM Test Summary: 31099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-23333

  20. Mathias Schreiber voted on patch set 11 V +1 CR +1 05/11/18, 15:34

  21. Anja Leichsenring voted on patch set 11 V +1 CR +1 05/11/18, 15:37

  22. Christian Kuhn voted on patch set 11 V +2 CR +2 05/11/18, 15:37

  23. Christian Kuhn merged patch set 12 05/11/18, 15:37

  24. Nicole Hummel commented on patch set 12 05/12/18, 01:38

    Post -1: IMHO we need to skip the new test if the used function is not available. Otherwise those tests will always fail.
  25. Oliver Hader commented on patch set 12 05/22/18, 08:59

    Cherry Picked This patchset was cherry picked to branch 9.2 as commit 31acd33197605f46531b2494d7b40484dfa35004