Review main Merged

55672[TASK] Use native array_replace_recursive implementation

Susi Moog CR +2 V +2 Normal +1 −134 updated 02/12/18, 13:55

Commit message

The custom implementation of array_replace_recursive in YamlSource
has been replaced with the native PHP version of the same method.

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Oliver Klee +1
    • Tobi Kretschmann +1
    • Andreas Kienast +1
    • Oliver Hader +1
    • Helmut Hummel +1
  • Verified V +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Tobi Kretschmann +1
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1112

  1. Susi Moog uploaded patch set 1 02/12/18, 11:15

  2. TYPO3com voted on patch set 1 V +1 02/12/18, 11:24 Completed build in 09m 06s on Mon, 12 Feb, 12:24 PM Test Summary: 30548 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19361

  3. Helmut Hummel commented on patch set 1 V +1 CR +1 02/12/18, 11:29

    YamlSourceTest.php:128

    note that the tests would still pass, with just using array_replace_recursive but we don't need tests for php functions, so fine to remove them again
  4. Stefan Neufeind voted on patch set 1 V +1 CR +1 02/12/18, 11:33

  5. Oliver Hader voted on patch set 1 CR +1 02/12/18, 11:38

  6. Markus Klein voted on patch set 1 CR +1 02/12/18, 11:57

  7. Andreas Kienast voted on patch set 1 CR +1 02/12/18, 12:14

  8. Oliver Klee voted on patch set 1 CR +1 02/12/18, 12:37

  9. Tobi Kretschmann voted on patch set 1 V +1 CR +1 02/12/18, 13:24

  10. Markus Klein voted on patch set 1 V +2 CR +2 02/12/18, 13:55

  11. Markus Klein merged patch set 2 02/12/18, 13:55

  12. Markus Klein commented on patch set 2 02/12/18, 13:55

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 990a0a8533b0a8d4aa88a1e9f9d15af88d0de413