Review main Merged

55673[TASK] Skip test for Yaml PHP extension if not loaded

Susi Moog CR +2 V +2 Easy +14 −13 updated 02/12/18, 13:36

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Tobi Kretschmann +1
    • Oliver Hader +1
    • Helmut Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Tobi Kretschmann +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Susi Moog uploaded patch set 1 02/12/18, 11:18

  2. Helmut Hummel voted on patch set 1 CR +1 02/12/18, 11:25

  3. TYPO3com voted on patch set 1 V +1 02/12/18, 11:29 Completed build in 11m 06s on Mon, 12 Feb, 12:29 PM Test Summary: 30566 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19363

  4. Stefan Neufeind commented on patch set 1 V +1 CR +1 02/12/18, 11:35

    Can't test without an installed yaml-extension - I guess my php has it compiled in. But should be fine.
  5. Christian Kuhn voted on patch set 1 V +2 CR +2 02/12/18, 11:37

  6. Christian Kuhn merged patch set 2 02/12/18, 11:37

  7. Christian Kuhn commented on patch set 2 02/12/18, 11:37

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit c5d64f2a78e25e95e740aba982acf4902a8fea29
  8. Oliver Hader voted on patch set 2 CR +1 02/12/18, 11:38

  9. Tobi Kretschmann voted on patch set 2 V +1 CR +1 02/12/18, 13:36