55689[BUGFIX] Show ImageMagick command on failure
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Mathias Schreiber +1
-
Verified V +2
- Christian Kuhn +2
- Mathias Schreiber +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 716
-
Tymoteusz Motylewski uploaded patch set 1 02/12/18, 21:03
-
TYPO3com voted on patch set 1 V -1 02/12/18, 21:12 Completed build in 08m 59s on Mon, 12 Feb, 10:12 PM Test Summary: 1 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19413
-
TYPO3com commented on patch set 1 02/12/18, 21:13 Completed build in 19m 13s on Mon, 12 Feb, 10:13 PM Test Summary: 1 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19413
-
TYPO3com commented on patch set 1 02/12/18, 21:15 Completed build in 31m 26s on Mon, 12 Feb, 10:15 PM Test Summary: 1 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19413
-
Christian Kuhn commented on patch set 1 CR -1 02/12/18, 21:15
maybe i'm doing something wrong tymek, could you help me?EnvironmentController.php:334this command does not seem to be output: if i "break" the image rendering by changing the call to: $imResult = $imageProcessor->imageMagickConvert($inputFile, 'kaputt', '300', '', '', '', [], true); then, the image generation actually fails, but the broken command is not output in the overview. -
TYPO3com commented on patch set 1 02/12/18, 21:16 Completed build in 44m 49s on Mon, 12 Feb, 10:16 PM Test Summary: 1 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19413
-
TYPO3com commented on patch set 1 02/12/18, 21:28 Completed build in 1h 10m 03s on Mon, 12 Feb, 10:28 PM Test Summary: 1 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19413
-
TYPO3com commented on patch set 1 02/12/18, 21:29 Completed build in 1h 36m 36s on Mon, 12 Feb, 10:29 PM Test Summary: 1 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19413
-
Mathias Schreiber commented on patch set 1 02/12/18, 21:30
EnvironmentController.php:334Replyit's a matter of HOW you break the command. GraphicalFunctions.php does a lot of checks outside of calling anything that writes into ->IM_commands -
TYPO3com commented on patch set 1 02/12/18, 21:30 Completed build in 2h 04m 21s on Mon, 12 Feb, 10:30 PM Test Summary: 1 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19413
-
TYPO3com commented on patch set 1 02/12/18, 21:31 Completed build in 2h 33m 14s on Mon, 12 Feb, 10:31 PM Test Summary: 1 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19413
-
TYPO3com voted on patch set 1 V +1 02/12/18, 21:34 Completed build in 3h 04m 23s on Mon, 12 Feb, 10:34 PM Test Summary: 30531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19413
-
Christian Kuhn voted on patch set 1 V +1 CR +1 02/12/18, 21:38
-
Mathias Schreiber voted on patch set 1 V +1 CR +1 02/12/18, 21:38
-
Christian Kuhn voted on patch set 1 V +2 CR +2 02/12/18, 21:39
-
Christian Kuhn merged patch set 2 02/12/18, 21:39