Review main Merged

5569[BUGFIX] TCEforms draws huge empty icon row which on select-fields

Benni Mack CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Certain fields of type "select" which offer records from a
"foreign_table" will contain a huge amount of t3-icon-empty
icons just below the select box. If you have enough of them,
you even get a horizotanl scrollbar.

See some screenshots here:
http://forge.typo3.org/issues/13422

The issue is not a CSS issue, but a bug in the rendering
of such a field.

See it in action in tt_content field "sys_language". Just create
enough sys_language records so that you see the row of empty
icons being created. This wasn't this way before.

Review

  • Code review CR +2
    • Dmitry Dulepov +2
    • Stefan Galinski +1
  • Verified V +2
    • Dmitry Dulepov +2
    • Stefan Galinski +1

Issues 1

Files 1

Review log 4

  1. Dmitry Dulepov commented on patch set 1 V 0 10/06/11, 11:50

    by team member; Looks good to me, approved tested, works.
  2. Stefan Galinski commented on patch set 1 10/06/11, 11:50

    Verified; Looks good to me, but someone else must approve
  3. Mr. Jenkins commented on patch set 1 10/06/11, 11:50

  4. Dmitry Dulepov merged patch set 1 10/06/11, 11:50