Review TYPO3_8-7 Merged

55698[BUGFIX] Add missing htmlspecialchars() calls and cleanup in QueryView

Frank Nägler CR +2 V +2 Normal +72 −96 updated 02/13/18, 19:39

Commit message

Add missing htmlspecialchars() calls in
EXT:core/Classes/Database/QueryView.php and do cleanup.

Review

  • Code review CR +2
    • Frank Nägler +2
  • Verified V +2
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 711

  1. Frank Nägler uploaded patch set 1 02/13/18, 14:39

  2. TYPO3com voted on patch set 1 V -1 02/13/18, 14:39 Completed build in 12s on Tue, 13 Feb, 03:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1837

  3. Frank Nägler uploaded patch set 2 02/13/18, 14:45

  4. TYPO3com voted on patch set 2 V -1 02/13/18, 14:48 Completed build in 09s on Tue, 13 Feb, 03:48 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1838

  5. Stephan Großberndt commented on patch set 2 02/13/18, 14:53

    QueryView.php:35

    Comment starts twice
  6. Stephan Großberndt uploaded patch set 3 02/13/18, 15:30

  7. Stephan Großberndt uploaded patch set 4 02/13/18, 15:33

  8. TYPO3com voted on patch set 3 V +1 02/13/18, 15:40 Completed build in 09m 41s on Tue, 13 Feb, 04:40 PM Test Summary: 58099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1839

  9. TYPO3com voted on patch set 4 V +1 02/13/18, 15:47 Completed build in 13m 41s on Tue, 13 Feb, 04:47 PM Test Summary: 58099 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1840

  10. Frank Nägler voted on patch set 4 V +2 CR +2 02/13/18, 19:39

  11. Frank Nägler merged patch set 5 02/13/18, 19:39