Review main Merged

55707[BUGFIX] Cleanup Spool Mailer feature

Benni Mack CR +2 V +2 Normal +132 −95 updated 02/14/18, 08:40

Commit message

The default file path is not set, so the admin has to set this
to a sensible default outside the web folder when he/she wants
to use it.

Additionally, some CGL fixes and cleanups are applied.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Markus Klein +1
  • Verified V +2
    • Georg Ringer +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 2

Files 10

Review log 1118

  1. Benni Mack uploaded patch set 1 02/13/18, 21:55

  2. Benni Mack commented on patch set 2 02/13/18, 21:59

    Published edit on patch set 1.
  3. TYPO3com voted on patch set 1 V -1 02/13/18, 22:05 Completed build in 09m 55s on Tue, 13 Feb, 11:05 PM Test Summary: 11 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19532

  4. TYPO3com voted on patch set 2 V -1 02/13/18, 22:14 Completed build in 14m 31s on Tue, 13 Feb, 11:14 PM Test Summary: 9 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19535

  5. Benni Mack uploaded patch set 3 02/13/18, 22:26

  6. TYPO3com voted on patch set 3 V -1 02/13/18, 22:36 Completed build in 09m 15s on Tue, 13 Feb, 11:36 PM Test Summary: 6 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19540

  7. Markus Klein commented on patch set 4 02/13/18, 22:43

    Published edit on patch set 3.
  8. Markus Klein commented on patch set 4 CR -1 02/13/18, 22:43

    will fix the tests
  9. TYPO3com voted on patch set 4 V -1 02/13/18, 22:51 Completed build in 07m 40s on Tue, 13 Feb, 11:51 PM Test Summary: 6 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19542

  10. Markus Klein uploaded patch set 5 02/13/18, 23:03

  11. TYPO3com voted on patch set 5 V +1 02/13/18, 23:11 Completed build in 08m 06s on Wed, 14 Feb, 12:11 AM Test Summary: 30531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19544

  12. Markus Klein voted on patch set 5 V +1 CR +1 02/13/18, 23:31

  13. Markus Klein commented on patch set 6 02/14/18, 00:08

    Published edit on patch set 5.
  14. Markus Klein voted on patch set 6 V +1 CR +1 02/14/18, 00:09

  15. TYPO3com voted on patch set 6 V -1 02/14/18, 00:17 Completed build in 08m 03s on Wed, 14 Feb, 01:17 AM Test Summary: 1 of 30689 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19547

  16. TYPO3com voted on patch set 6 V +1 02/14/18, 00:29 Completed build in 28m 21s on Wed, 14 Feb, 01:29 AM Test Summary: 30531 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19547

  17. Georg Ringer commented on patch set 6 V +2 CR +2 02/14/18, 08:40

    DefaultConfigurationDescription.yaml:490 Unresolved

    sent
  18. Georg Ringer merged patch set 7 02/14/18, 08:40