Review main Merged

55713[BUGFIX] Show duplicate button only if it makes sense

Frank Nägler CR +2 V +2 Easy +20 −0 updated 02/15/18, 15:18

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 912

  1. Frank Nägler uploaded patch set 1 02/14/18, 12:11

  2. Frank Nägler updated the commit message in patch set 2 02/14/18, 12:16

  3. TYPO3com voted on patch set 1 V +1 02/14/18, 12:19 Completed build in 08m 35s on Wed, 14 Feb, 01:19 PM Test Summary: 30537 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19560

  4. TYPO3com voted on patch set 2 V +1 02/14/18, 12:23 Completed build in 07m 36s on Wed, 14 Feb, 01:23 PM Test Summary: 30537 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19561

  5. Frank Nägler updated the commit message in patch set 3 02/14/18, 21:17

  6. TYPO3com voted on patch set 3 V +1 02/14/18, 21:26 Completed build in 08m 58s on Wed, 14 Feb, 10:26 PM Test Summary: 30771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19605

  7. Anja Leichsenring commented on patch set 3 02/14/18, 21:31

    would you mind to be a little bit more descriptive with the commit message?
  8. Mathias Schreiber voted on patch set 3 V +1 CR +1 02/14/18, 22:24

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 02/15/18, 01:29

  10. Christian Kuhn merged patch set 4 02/15/18, 01:29

  11. Helmut Hummel commented on patch set 4 02/15/18, 15:18

    EditDocumentController.php:1333

    both field names can be configured in TCA and thus should not be hardcoded here. also: there are tables which have no translation enabled
  12. Helmut Hummel commented on patch set 4 02/15/18, 15:18

    post -1