Review main Merged

55714[TASK] Set about module free from Extbase

Benni Mack CR +2 V +2 Normal +47 −28 updated 02/14/18, 21:31

Commit message

The whole Extbase stack for the about module
is not necessary, as there is only one action
in this controller, and it's a simple Fluid
action.

The module name is kept as "help_AboutAbout"
due to the uncool naming handling of Extbase magic.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1420

  1. Benni Mack uploaded patch set 1 02/14/18, 13:06

  2. TYPO3com voted on patch set 1 V +1 02/14/18, 13:16 Completed build in 09m 09s on Wed, 14 Feb, 02:16 PM Test Summary: 30771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19565

  3. Benni Mack uploaded patch set 2 02/14/18, 13:43

  4. TYPO3com voted on patch set 2 V +1 02/14/18, 13:51 Completed build in 07m 25s on Wed, 14 Feb, 02:51 PM Test Summary: 30771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19568

  5. Benni Mack updated the commit message in patch set 3 02/14/18, 16:09

  6. TYPO3com voted on patch set 3 V -1 02/14/18, 16:19 Completed build in 10m 18s on Wed, 14 Feb, 05:19 PM Test Summary: 1 of 30929 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19583

  7. TYPO3com voted on patch set 3 V +1 02/14/18, 16:42 Completed build in 43m 06s on Wed, 14 Feb, 05:42 PM Test Summary: 30771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19583

  8. Anja Leichsenring voted on patch set 3 V +1 CR +1 02/14/18, 17:03

  9. Wouter Wolters voted on patch set 3 CR +1 02/14/18, 17:57

  10. Mathias Schreiber commented on patch set 3 V -1 02/14/18, 21:00

    will fix template path
  11. Mathias Schreiber uploaded patch set 4 02/14/18, 21:02

  12. Mathias Schreiber voted on patch set 4 V +1 CR +1 02/14/18, 21:04

  13. TYPO3com voted on patch set 4 V +1 02/14/18, 21:11 Completed build in 08m 53s on Wed, 14 Feb, 10:11 PM Test Summary: 30771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19602

  14. Christian Kuhn commented on patch set 4 02/14/18, 21:20

    this part isn't true anymore, no?
  15. Benni Mack updated the commit message in patch set 5 02/14/18, 21:21

  16. Christian Kuhn voted on patch set 5 V +1 CR +1 02/14/18, 21:25

  17. TYPO3com voted on patch set 5 V +1 02/14/18, 21:30 Completed build in 08m 48s on Wed, 14 Feb, 10:30 PM Test Summary: 30771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19606

  18. Mathias Schreiber voted on patch set 5 V +1 CR +1 02/14/18, 21:31

  19. Christian Kuhn voted on patch set 5 V +2 CR +2 02/14/18, 21:31

  20. Christian Kuhn merged patch set 6 02/14/18, 21:31