Review main Merged

55719[TASK] Move check if workspaces extension is loaded to the controller

Georg Ringer CR +2 V +2 Normal +3 −52 updated 02/14/18, 21:36

Commit message

Instead of using a ViewHelper the logic can be moved to the controller
where it belongs.

As the ViewHelper is not a public API it can be dropped without a
RST file.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Oliver Klee +1
    • Wouter Wolters +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 78

  1. Georg Ringer uploaded patch set 1 02/14/18, 16:13

  2. TYPO3com voted on patch set 1 V +1 02/14/18, 16:22 Completed build in 08m 34s on Wed, 14 Feb, 05:22 PM Test Summary: 30771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19584

  3. Wouter Wolters voted on patch set 1 CR +1 02/14/18, 17:59

  4. Oliver Klee voted on patch set 1 CR +1 02/14/18, 18:02

  5. Mathias Schreiber voted on patch set 1 V +1 CR +1 02/14/18, 20:48

  6. Anja Leichsenring voted on patch set 1 V +1 CR +1 02/14/18, 21:33

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 02/14/18, 21:36

  8. Christian Kuhn merged patch set 2 02/14/18, 21:36