Review main Merged

55722[TASK] Deprecate array handling in AbstractTreeView

Christian Kuhn CR +2 V +2 Normal +94 −3 updated 02/18/18, 12:31

Commit message

The array handling in AbstractTreeView has not been used
in the core for quite some while. To clean that class up
a bit, the functionality is now deprecated.

Deprecation is covered by the extension scanner, except the
class property $this->data which is too common and would
create way too many false positives.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Anja Leichsenring +1
  • Verified V +2
    • Andreas Wolf +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 57

  1. Christian Kuhn uploaded patch set 1 02/14/18, 23:05

  2. TYPO3com voted on patch set 1 V +1 02/14/18, 23:14 Completed build in 08m 34s on Thu, 15 Feb, 12:14 AM Test Summary: 30771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19614

  3. Anja Leichsenring uploaded patch set 2 02/16/18, 20:38

  4. Anja Leichsenring voted on patch set 2 V +1 CR +1 02/16/18, 20:42

  5. TYPO3com voted on patch set 2 V +1 02/16/18, 20:47 Completed build in 08m 21s on Fri, 16 Feb, 09:47 PM Test Summary: 30863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19754

  6. Andreas Wolf voted on patch set 2 V +2 CR +2 02/18/18, 12:31

  7. Andreas Wolf merged patch set 3 02/18/18, 12:31