Review main Merged

55723[TASK] Deprecate TypoScriptFrontendController->page_cache_reg1

Christian Kuhn CR +2 V +2 Normal +56 −1 updated 02/16/18, 16:50

Commit message

Property page_cache_reg1 is a poor man limited way to manipulate
page cache tagging. It has been of very little use and is
deprecated now.

The usage in indexed_search (which always only added the default "0"
to database) is dropped along the way.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 57

  1. Christian Kuhn uploaded patch set 1 02/14/18, 23:41

  2. TYPO3com voted on patch set 1 V -1 02/14/18, 23:49 Completed build in 07m 57s on Thu, 15 Feb, 12:49 AM Test Summary: 1 of 30929 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19615

  3. TYPO3com voted on patch set 1 V +1 02/15/18, 00:39 Completed build in 1h 05m 32s on Thu, 15 Feb, 01:39 AM Test Summary: 30771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19615

  4. Benni Mack voted on patch set 1 V +1 CR +1 02/16/18, 13:01

  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 02/16/18, 16:49

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 02/16/18, 16:50

  7. Christian Kuhn merged patch set 2 02/16/18, 16:50