Review main Merged

55728[TASK] Allow chaining in class ModuleTemplate

Christian Kuhn CR +2 V +2 Easy +36 −12 updated 02/15/18, 11:51

Commit message

For slightly more dense code ModuleTemplate now
returns $this on setter methods to allow chaining.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Christian Kuhn uploaded patch set 1 02/15/18, 03:56

  2. TYPO3com voted on patch set 1 V +1 02/15/18, 04:04 Completed build in 07m 28s on Thu, 15 Feb, 05:04 AM Test Summary: 30771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19623

  3. Björn Jacob commented on patch set 1 02/15/18, 07:12

    For better readability maybe set "ModuleTemplate" in quotation marks or such.
    "Releases"
  4. Christian Kuhn updated the commit message in patch set 2 02/15/18, 09:03

  5. TYPO3com voted on patch set 2 V +1 02/15/18, 09:11 Completed build in 08m 11s on Thu, 15 Feb, 10:11 AM Test Summary: 30771 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19627

  6. Frank Nägler voted on patch set 2 V +1 CR +1 02/15/18, 09:41

  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 02/15/18, 10:12

  8. Mathias Schreiber voted on patch set 2 V +1 CR +1 02/15/18, 10:26

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 02/15/18, 11:51

  10. Christian Kuhn merged patch set 3 02/15/18, 11:51