Review main Merged

55733[TASK] Move HTML generation in RemoveUserViewHelper to the view

Georg Ringer CR +2 V +2 Normal +25 −40 updated 02/17/18, 19:39

Commit message

Instead of creating the HTML in the ViewHelper it should be done in
the template.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 813

  1. Georg Ringer uploaded patch set 1 02/15/18, 12:44

  2. TYPO3com voted on patch set 1 V -1 02/15/18, 12:44 Completed build in 10s on Thu, 15 Feb, 01:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19647

  3. Benni Mack rebased onto patch set 2 02/15/18, 16:03

  4. TYPO3com voted on patch set 2 V -1 02/15/18, 16:03 Completed build in 14s on Thu, 15 Feb, 05:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19657

  5. Oliver Klee commented on patch set 3 02/15/18, 17:05

    Published edit on patch set 2.
  6. TYPO3com voted on patch set 3 V -1 02/15/18, 17:06 Completed build in 09s on Thu, 15 Feb, 06:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19662

  7. TYPO3com commented on patch set 3 02/15/18, 18:56 Completed build in 43s on Thu, 15 Feb, 07:56 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19662

  8. Andreas Kienast uploaded patch set 4 02/15/18, 19:16

  9. TYPO3com voted on patch set 4 V +1 02/15/18, 19:25 Completed build in 09m 03s on Thu, 15 Feb, 08:25 PM Test Summary: 30825 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19673

  10. Benni Mack voted on patch set 4 V +1 CR +1 02/16/18, 20:13

  11. Mathias Schreiber voted on patch set 4 V +1 CR +1 02/17/18, 18:47

  12. Christian Kuhn voted on patch set 4 V +2 CR +2 02/17/18, 19:39

  13. Christian Kuhn merged patch set 5 02/17/18, 19:39