55733[TASK] Move HTML generation in RemoveUserViewHelper to the view
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Mathias Schreiber +1
- Benni Mack +1
-
Verified V +2
- Christian Kuhn +2
- Mathias Schreiber +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+1 −0
- typo3/sysext/beuser/Classes/ViewHelpers/RemoveUserViewHelper.php+4 −33
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/IndexListRow.html+15 −1
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/PaginatedListWidget.html+1 −1
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/PaginatedListWidgetBody.html+2 −2
- typo3/sysext/beuser/Resources/Private/Partials/BackendUserGroup/PaginatedListWidgetBody.html+2 −2
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Index.html+0 −1
Review log 813
-
Georg Ringer uploaded patch set 1 02/15/18, 12:44
-
TYPO3com voted on patch set 1 V -1 02/15/18, 12:44 Completed build in 10s on Thu, 15 Feb, 01:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19647
-
Benni Mack rebased onto patch set 2 02/15/18, 16:03
-
TYPO3com voted on patch set 2 V -1 02/15/18, 16:03 Completed build in 14s on Thu, 15 Feb, 05:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19657
-
Oliver Klee commented on patch set 3 02/15/18, 17:05
Published edit on patch set 2. -
TYPO3com voted on patch set 3 V -1 02/15/18, 17:06 Completed build in 09s on Thu, 15 Feb, 06:06 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19662
-
TYPO3com commented on patch set 3 02/15/18, 18:56 Completed build in 43s on Thu, 15 Feb, 07:56 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19662
-
Andreas Kienast uploaded patch set 4 02/15/18, 19:16
-
TYPO3com voted on patch set 4 V +1 02/15/18, 19:25 Completed build in 09m 03s on Thu, 15 Feb, 08:25 PM Test Summary: 30825 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19673
-
Benni Mack voted on patch set 4 V +1 CR +1 02/16/18, 20:13
-
Mathias Schreiber voted on patch set 4 V +1 CR +1 02/17/18, 18:47
-
Christian Kuhn voted on patch set 4 V +2 CR +2 02/17/18, 19:39
-
Christian Kuhn merged patch set 5 02/17/18, 19:39