Review main Merged

55734[TASK] Remove unused ViewHelpers from extension manager

Georg Ringer CR +2 V +2 Normal +33 −173 updated 02/19/18, 10:58

Commit message

Several ViewHelpers inside the extension maanger are not used and
can be removed. As those are not public API no RST file or deprecation
is required.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Sascha Rademacher +1
    • Tobi Kretschmann +1
    • Jan Stockfisch +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Jan Stockfisch +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1323

  1. Georg Ringer uploaded patch set 1 02/15/18, 12:53

  2. TYPO3com voted on patch set 1 V -1 02/15/18, 13:01 Completed build in 07m 45s on Thu, 15 Feb, 02:01 PM Test Summary: 9 of 30983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19649

  3. Georg Ringer rebased onto patch set 2 02/16/18, 14:33

  4. TYPO3com voted on patch set 2 V -1 02/16/18, 14:42 Completed build in 09m 08s on Fri, 16 Feb, 03:42 PM Test Summary: 3 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19709

  5. Georg Ringer updated the commit message in patch set 3 02/16/18, 15:13

  6. TYPO3com voted on patch set 3 V -1 02/16/18, 15:21 Completed build in 07m 59s on Fri, 16 Feb, 04:21 PM Test Summary: 4 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19717

  7. Georg Ringer uploaded patch set 4 02/16/18, 16:06

  8. TYPO3com voted on patch set 4 V -1 02/16/18, 16:13 Completed build in 07m 45s on Fri, 16 Feb, 05:13 PM Test Summary: 1 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19723

  9. TYPO3com commented on patch set 4 02/16/18, 16:32 Completed build in 34m 22s on Fri, 16 Feb, 05:32 PM Test Summary: 1 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19723

  10. TYPO3com commented on patch set 4 02/16/18, 16:39 Completed build in 1h 07m 29s on Fri, 16 Feb, 05:39 PM Test Summary: 1 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19723

  11. TYPO3com commented on patch set 4 02/16/18, 16:40 Completed build in 1h 41m 42s on Fri, 16 Feb, 05:40 PM Test Summary: 1 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19723

  12. TYPO3com commented on patch set 4 02/16/18, 16:40 Completed build in 2h 16m 31s on Fri, 16 Feb, 05:40 PM Test Summary: 1 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19723

  13. TYPO3com commented on patch set 4 02/16/18, 16:41 Completed build in 2h 51m 55s on Fri, 16 Feb, 05:41 PM Test Summary: 1 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19723

  14. Christian Kuhn rebased onto patch set 5 02/16/18, 20:30

  15. TYPO3com voted on patch set 5 V +1 02/16/18, 20:39 Completed build in 09m 39s on Fri, 16 Feb, 09:39 PM Test Summary: 30863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19751

  16. Mathias Schreiber commented on patch set 5 V +1 CR +1 02/17/18, 18:44

    ToggleExtensionInstallationStateViewHelper.php:41

    where is this used?
  17. Georg Ringer commented on patch set 5 02/18/18, 17:38

    > Patch Set 5: Verified+1 Code-Review+1 > > (1 comment)

    ToggleExtensionInstallationStateViewHelper.php:41 Reply

    > where is this used? $packageManager = $this->objectManager->get(PackageManager::class);
  18. Mathias Schreiber commented on patch set 5 02/18/18, 20:04

    ToggleExtensionInstallationStateViewHelper.php:41 Reply

    ok, but it's in the ActionViewhelper as well. Do you intent to remove it there later?
  19. Tobi Kretschmann commented on patch set 5 CR +1 02/19/18, 08:41

    ToggleExtensionInstallationStateViewHelper.php:41 Reply Unresolved

    > ok, but it's in the ActionViewhelper as well. Do you intent to > remove it there later? It used to be in the ActionViewHelper located in /extensionmanager. But now it extends the /fluid ActionViewHelper and there ist no such method
  20. Sascha Rademacher voted on patch set 5 CR +1 02/19/18, 08:51

  21. Jan Stockfisch voted on patch set 5 V +1 CR +1 02/19/18, 10:24

  22. Christian Kuhn voted on patch set 5 V +2 CR +2 02/19/18, 10:58

  23. Christian Kuhn merged patch set 6 02/19/18, 10:58