55734[TASK] Remove unused ViewHelpers from extension manager
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Mathias Schreiber +1
- Sascha Rademacher +1
- Tobi Kretschmann +1
- Jan Stockfisch +1
-
Verified V +2
- Christian Kuhn +2
- Mathias Schreiber +1
- Jan Stockfisch +1
- TYPO3com +1 CI
Issues 1
Files 8
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Format/ImplodeViewHelper.phpdeleted+0 −51
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Link/ActionViewHelper.phpdeleted+0 −56
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ReloadSqlDataViewHelper.php+2 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/RemoveExtensionViewHelper.php+2 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ShowExtensionVersionsViewHelper.php+2 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/TimeSinceLastUpdateViewHelper.phpdeleted+0 −61
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ToggleExtensionInstallationStateViewHelper.php4+13 −1
- typo3/sysext/extensionmanager/Classes/ViewHelpers/UpdateScriptViewHelper.php+14 −1
Review log 1323
-
Georg Ringer uploaded patch set 1 02/15/18, 12:53
-
TYPO3com voted on patch set 1 V -1 02/15/18, 13:01 Completed build in 07m 45s on Thu, 15 Feb, 02:01 PM Test Summary: 9 of 30983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19649
-
Georg Ringer rebased onto patch set 2 02/16/18, 14:33
-
TYPO3com voted on patch set 2 V -1 02/16/18, 14:42 Completed build in 09m 08s on Fri, 16 Feb, 03:42 PM Test Summary: 3 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19709
-
Georg Ringer updated the commit message in patch set 3 02/16/18, 15:13
-
TYPO3com voted on patch set 3 V -1 02/16/18, 15:21 Completed build in 07m 59s on Fri, 16 Feb, 04:21 PM Test Summary: 4 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19717
-
Georg Ringer uploaded patch set 4 02/16/18, 16:06
-
TYPO3com voted on patch set 4 V -1 02/16/18, 16:13 Completed build in 07m 45s on Fri, 16 Feb, 05:13 PM Test Summary: 1 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19723
-
TYPO3com commented on patch set 4 02/16/18, 16:32 Completed build in 34m 22s on Fri, 16 Feb, 05:32 PM Test Summary: 1 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19723
-
TYPO3com commented on patch set 4 02/16/18, 16:39 Completed build in 1h 07m 29s on Fri, 16 Feb, 05:39 PM Test Summary: 1 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19723
-
TYPO3com commented on patch set 4 02/16/18, 16:40 Completed build in 1h 41m 42s on Fri, 16 Feb, 05:40 PM Test Summary: 1 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19723
-
TYPO3com commented on patch set 4 02/16/18, 16:40 Completed build in 2h 16m 31s on Fri, 16 Feb, 05:40 PM Test Summary: 1 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19723
-
TYPO3com commented on patch set 4 02/16/18, 16:41 Completed build in 2h 51m 55s on Fri, 16 Feb, 05:41 PM Test Summary: 1 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19723
-
Christian Kuhn rebased onto patch set 5 02/16/18, 20:30
-
TYPO3com voted on patch set 5 V +1 02/16/18, 20:39 Completed build in 09m 39s on Fri, 16 Feb, 09:39 PM Test Summary: 30863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19751
-
Mathias Schreiber commented on patch set 5 V +1 CR +1 02/17/18, 18:44
-
Georg Ringer commented on patch set 5 02/18/18, 17:38
> Patch Set 5: Verified+1 Code-Review+1 > > (1 comment)ToggleExtensionInstallationStateViewHelper.php:41Reply> where is this used? $packageManager = $this->objectManager->get(PackageManager::class); -
Mathias Schreiber commented on patch set 5 02/18/18, 20:04
ToggleExtensionInstallationStateViewHelper.php:41Replyok, but it's in the ActionViewhelper as well. Do you intent to remove it there later? -
Tobi Kretschmann commented on patch set 5 CR +1 02/19/18, 08:41
ToggleExtensionInstallationStateViewHelper.php:41Reply Unresolved> ok, but it's in the ActionViewhelper as well. Do you intent to > remove it there later? It used to be in the ActionViewHelper located in /extensionmanager. But now it extends the /fluid ActionViewHelper and there ist no such method -
Sascha Rademacher voted on patch set 5 CR +1 02/19/18, 08:51
-
Jan Stockfisch voted on patch set 5 V +1 CR +1 02/19/18, 10:24
-
Christian Kuhn voted on patch set 5 V +2 CR +2 02/19/18, 10:58
-
Christian Kuhn merged patch set 6 02/19/18, 10:58
ToggleExtensionInstallationStateViewHelper.php:41