Review main Merged

55735[TASK] Remove ClickMenuOnIconViewHelper of filelist extension

Georg Ringer CR +2 V +2 Normal +2 −58 updated 02/16/18, 16:30

Commit message

Move the templating code into the template instead of using a
ViewHelper.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Tymoteusz Motylewski +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1216

  1. Georg Ringer uploaded patch set 1 02/15/18, 13:01

  2. TYPO3com voted on patch set 1 V -1 02/15/18, 13:09 Completed build in 07m 33s on Thu, 15 Feb, 02:09 PM Test Summary: 4 of 30983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19650

  3. Benni Mack rebased onto patch set 2 02/15/18, 16:03

  4. TYPO3com voted on patch set 2 V -1 02/15/18, 16:17 Completed build in 13m 42s on Thu, 15 Feb, 05:17 PM Test Summary: 2 of 30983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19659

  5. TYPO3com voted on patch set 2 V +1 02/15/18, 18:51 Completed build in 3h 01m 05s on Thu, 15 Feb, 07:51 PM Test Summary: 30825 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19659

  6. Andreas Kienast commented on patch set 2 CR -1 02/15/18, 19:20

    fl:link.clickMenuOnIcon is used in a lot of fixtures for unit tests.
  7. Andreas Kienast commented on patch set 2 V +1 CR +1 02/15/18, 19:21

    It seems the fixtures are not used anymore.
  8. Wouter Wolters voted on patch set 2 CR +1 02/15/18, 19:45

  9. Benni Mack commented on patch set 3 02/15/18, 20:46

    Published edit on patch set 2.
  10. Andreas Kienast voted on patch set 3 V +1 CR +1 02/15/18, 20:49

  11. TYPO3com voted on patch set 3 V +1 02/15/18, 20:55 Completed build in 08m 23s on Thu, 15 Feb, 09:55 PM Test Summary: 30825 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19683

  12. Tymoteusz Motylewski voted on patch set 3 CR +1 02/16/18, 12:06

  13. Mathias Schreiber voted on patch set 3 V +1 CR +1 02/16/18, 15:08

  14. Christian Kuhn voted on patch set 3 V +2 CR +2 02/16/18, 16:29

  15. Christian Kuhn merged patch set 4 02/16/18, 16:29

  16. Christian Kuhn commented on patch set 4 02/16/18, 16:30

    nice!