Review main Merged

55741[BUGFIX] Use language fields as defined in TCA for „Duplicate“

Andreas Kienast CR +2 V +2 Easy +12 −14 updated 02/19/18, 11:19

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 1619

  1. Andreas Kienast uploaded patch set 1 02/15/18, 19:03

  2. Mathias Schreiber commented on patch set 1 V +1 CR +1 02/15/18, 19:06

    that's the followup for Helmut's remark, right?
  3. TYPO3com voted on patch set 1 V +1 02/15/18, 19:11 Completed build in 07m 34s on Thu, 15 Feb, 08:11 PM Test Summary: 30825 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19671

  4. Andreas Kienast commented on patch set 1 02/15/18, 19:13

    > that's the followup for Helmut's remark, right? That's right
  5. Andreas Kienast updated the commit message in patch set 2 02/15/18, 19:13

  6. Mathias Schreiber voted on patch set 2 V +1 CR +1 02/15/18, 19:18

  7. TYPO3com voted on patch set 2 V +1 02/15/18, 19:22 Completed build in 09m 17s on Thu, 15 Feb, 08:22 PM Test Summary: 30825 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19672

  8. Frank Nägler voted on patch set 2 CR +1 02/15/18, 21:11

  9. Sybille Peters voted on patch set 2 V +1 CR +1 02/15/18, 21:52

  10. Helmut Hummel commented on patch set 2 CR -1 02/16/18, 09:06

    EditDocumentController.php:1333

    $TCActrl['transOrigPointerField'] and $TCActrl['languageField'] aren't necessarily set for a table. accessing them introduces two new notices for such cases

    EditDocumentController.php:1338

    I still don't understand why we need to have a special case for pages here since pages translation works exactly the same as any other table for a while
  11. Andreas Kienast commented on patch set 2 02/16/18, 09:12

    EditDocumentController.php:1333 Reply

    Shouldn't this get covered by the null coalesce on the right?

    EditDocumentController.php:1338 Reply

    IIRC it has to do with connected <> free mode, which you don't have for pages.
  12. Helmut Hummel commented on patch set 2 02/16/18, 09:33

    EditDocumentController.php:1333 Reply

    no. coalesce is used for $record not for $TCActrl

    EditDocumentController.php:1338 Reply

    there are two cases for which the button shall be shown: 1. record is not translated 2. record is translated but has no parent 2. can never happen for pages, true. but I still don't understand why we need make a special case for pages here
  13. Andreas Kienast commented on patch set 2 02/16/18, 09:35

    EditDocumentController.php:1333 Reply

    True

    EditDocumentController.php:1338 Reply

    Will test without the special treatment
  14. Andreas Kienast voted on patch set 2 CR -1 02/16/18, 09:35

  15. Andreas Kienast uploaded patch set 3 02/16/18, 09:43

  16. TYPO3com voted on patch set 3 V +1 02/16/18, 09:52 Completed build in 08m 42s on Fri, 16 Feb, 10:52 AM Test Summary: 30812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19693

  17. Mathias Schreiber voted on patch set 3 V +1 CR +1 02/18/18, 14:05

  18. Christian Kuhn voted on patch set 3 V +2 CR +2 02/19/18, 11:19

  19. Christian Kuhn merged patch set 4 02/19/18, 11:19