Review main Merged

55743[BUGFIX] Respect casing in CommandLineBackendUserRemovalUpdate

Anja Leichsenring CR +2 V +2 Normal +60 −9 updated 02/17/18, 19:48

Commit message

System extensions used to create their _cli_* users lowercased.
The wizard queries only for uppercase varieties. Adding a LOWER
command to the where-clause catches now all casings.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2542

Show 817 earlier messages
  1. Anja Leichsenring uploaded patch set 1 02/15/18, 19:28

  2. Anja Leichsenring uploaded patch set 2 02/15/18, 19:29

  3. Anja Leichsenring uploaded patch set 3 02/15/18, 19:30

  4. TYPO3com voted on patch set 1 V -1 02/15/18, 19:38 Completed build in 09m 56s on Thu, 15 Feb, 08:38 PM Test Summary: 1 of 30985 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19675

  5. TYPO3com voted on patch set 2 V -1 02/15/18, 19:41 Completed build in 11m 30s on Thu, 15 Feb, 08:41 PM Test Summary: 1 of 30985 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19676

  6. TYPO3com voted on patch set 3 V -1 02/15/18, 19:44 Completed build in 13m 59s on Thu, 15 Feb, 08:44 PM Test Summary: 1 of 30985 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19679

  7. Anja Leichsenring uploaded patch set 4 02/15/18, 19:52

  8. TYPO3com voted on patch set 4 V -1 02/15/18, 20:01 Completed build in 08m 51s on Thu, 15 Feb, 09:01 PM Test Summary: 1 of 30985 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19681

  9. Anja Leichsenring uploaded patch set 5 02/15/18, 20:18

  10. TYPO3com voted on patch set 5 V -1 02/15/18, 20:26 Completed build in 08m 36s on Thu, 15 Feb, 09:26 PM Test Summary: 1 of 30985 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19682

  11. Anja Leichsenring uploaded patch set 6 02/15/18, 20:57

  12. TYPO3com voted on patch set 6 V -1 02/15/18, 21:07 Completed build in 09m 03s on Thu, 15 Feb, 10:07 PM Test Summary: 2 of 30985 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19685

  13. Anja Leichsenring uploaded patch set 7 02/15/18, 21:11

  14. TYPO3com voted on patch set 7 V -1 02/15/18, 21:15 Completed build in 03m 44s on Thu, 15 Feb, 10:15 PM Test Summary: 1 of 28479 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19686

  15. Anja Leichsenring updated the commit message in patch set 8 02/15/18, 21:16

  16. TYPO3com voted on patch set 7 V +1 02/15/18, 21:24 Completed build in 17m 05s on Thu, 15 Feb, 10:24 PM Test Summary: 1 of 30985 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19686

  17. TYPO3com voted on patch set 8 V +1 02/15/18, 21:25 Completed build in 08m 48s on Thu, 15 Feb, 10:25 PM Test Summary: 30814 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19687

  1. Anja Leichsenring uploaded patch set 9 02/15/18, 21:26

  2. Anja Leichsenring uploaded patch set 10 02/15/18, 21:27

  3. TYPO3com voted on patch set 9 V +1 02/15/18, 21:35 Completed build in 08m 57s on Thu, 15 Feb, 10:35 PM Test Summary: 30814 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19688

  4. TYPO3com voted on patch set 10 V -1 02/15/18, 21:36 Completed build in 09m 42s on Thu, 15 Feb, 10:36 PM Test Summary: 1 of 30971 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19689

  5. TYPO3com voted on patch set 10 V +1 02/15/18, 21:47 Completed build in 30m 14s on Thu, 15 Feb, 10:47 PM Test Summary: 30814 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19689

  6. Anja Leichsenring commented on patch set 10 CR -1 02/16/18, 16:50

    will add (or rather substract) some improvements
  7. Anja Leichsenring uploaded patch set 11 02/16/18, 19:43

  8. TYPO3com voted on patch set 11 V +1 02/16/18, 19:51 Completed build in 08m 05s on Fri, 16 Feb, 08:51 PM Test Summary: 30865 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19742

  9. Anja Leichsenring uploaded patch set 12 02/16/18, 20:03

  10. Anja Leichsenring updated the commit message in patch set 13 02/16/18, 20:07

  11. TYPO3com voted on patch set 12 V +1 02/16/18, 20:17 Completed build in 13m 16s on Fri, 16 Feb, 09:17 PM Test Summary: 30865 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19745

  12. TYPO3com voted on patch set 13 V -1 02/16/18, 20:18 Completed build in 10m 40s on Fri, 16 Feb, 09:18 PM Test Summary: 1 of 31016 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19746

  13. TYPO3com voted on patch set 13 V +1 02/16/18, 20:50 Completed build in 53m 17s on Fri, 16 Feb, 09:50 PM Test Summary: 30865 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19746

  14. Andreas Kienast voted on patch set 13 V +1 CR +1 02/17/18, 15:53

  15. Mathias Schreiber voted on patch set 13 V +1 CR +1 02/17/18, 18:38

  16. Christian Kuhn commented on patch set 13 CR -1 02/17/18, 19:12

    on it, will push again.

    CommandLineBackendUserRemovalUpdate.php:48

    this is not true anymore, right?
  17. Christian Kuhn uploaded patch set 14 02/17/18, 19:20

  18. Christian Kuhn commented on patch set 14 02/17/18, 19:21

    simplified a bit more.
  19. Anja Leichsenring voted on patch set 14 V +1 CR +1 02/17/18, 19:22

  20. TYPO3com voted on patch set 14 V +1 02/17/18, 19:30 Completed build in 09m 59s on Sat, 17 Feb, 08:30 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19796

  21. Mathias Schreiber voted on patch set 14 V +1 CR +1 02/17/18, 19:31

  22. Christian Kuhn commented on patch set 14 02/17/18, 19:32

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 31eaee391f4ec36923f0c3882810b17091644322
  23. Christian Kuhn commented on patch set 14 02/17/18, 19:32

    cherry-pick to 8.7 before merge to see if it goes green there, too.
  24. Christian Kuhn voted on patch set 14 V +2 CR +2 02/17/18, 19:48

  25. Christian Kuhn merged patch set 15 02/17/18, 19:48