55754[TASK] Create own response instance in controller actions
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Mathias Schreiber +1
- Anja Leichsenring +1
- Benjamin Kott +1
-
Verified V +2
- Christian Kuhn +2
- Mathias Schreiber +1
- Anja Leichsenring +1
- Benjamin Kott +1
- TYPO3com +1 CI
Issues 1
Files 74
- typo3/sysext/about/Classes/Controller/AboutController.php+1 −3
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ShortcutToolbarItem.php+72 −89
- typo3/sysext/backend/Classes/Backend/ToolbarItems/SystemInformationToolbarItem.php+9 −10
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+3 −4
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+3 −5
- typo3/sysext/backend/Classes/Controller/ContentElement/MoveElementController.php+3 −5
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+5 −8
- typo3/sysext/backend/Classes/Controller/File/CreateFolderController.php+3 −4
- typo3/sysext/backend/Classes/Controller/File/EditFileController.php+3 −5
- typo3/sysext/backend/Classes/Controller/File/FileController.php+24 −28
- typo3/sysext/backend/Classes/Controller/File/FileUploadController.php+3 −5
- typo3/sysext/backend/Classes/Controller/File/RenameFileController.php+3 −5
- typo3/sysext/backend/Classes/Controller/File/ReplaceFileController.php+3 −5
- typo3/sysext/backend/Classes/Controller/Page/LocalizationController.php+11 −18
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php+4 −6
- typo3/sysext/backend/Classes/Controller/Page/SortSubPagesController.php+4 −6
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+3 −3
- typo3/sysext/backend/Classes/Controller/Wizard/AddController.php+3 −3
- typo3/sysext/backend/Classes/Controller/Wizard/EditController.php+3 −4
- typo3/sysext/backend/Classes/Controller/Wizard/ListController.php+3 −3
Show 54 more files
- typo3/sysext/backend/Classes/Controller/Wizard/SuggestWizardController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Wizard/TableController.php+3 −4
- typo3/sysext/backend/Classes/Controller/AjaxLoginController.php+4 −5
- typo3/sysext/backend/Classes/Controller/BackendController.php+7 −12
- typo3/sysext/backend/Classes/Controller/ContextHelpAjaxController.php+10 −10
- typo3/sysext/backend/Classes/Controller/ContextMenuController.php+2 −2
- typo3/sysext/backend/Classes/Controller/DummyController.php+9 −36
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+3 −4
- typo3/sysext/backend/Classes/Controller/FileSystemNavigationFrameController.php+6 −9
- typo3/sysext/backend/Classes/Controller/FlashMessageController.php+2 −4
- typo3/sysext/backend/Classes/Controller/FormFlexAjaxController.php+1 −1
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+4 −4
- typo3/sysext/backend/Classes/Controller/FormSelectTreeAjaxController.php+1 −1
- typo3/sysext/backend/Classes/Controller/LinkBrowserController.php+1 −1
- typo3/sysext/backend/Classes/Controller/LiveSearchController.php+1 −1
- typo3/sysext/backend/Classes/Controller/LoginController.php+3 −5
- typo3/sysext/backend/Classes/Controller/LoginFramesetController.php+3 −4
- typo3/sysext/backend/Classes/Controller/LogoutController.php+5 −7
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+3 −5
- typo3/sysext/backend/Classes/Controller/OnlineMediaController.php+6 −5
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+3 −4
- typo3/sysext/backend/Classes/Controller/SimpleDataHandlerController.php+6 −7
- typo3/sysext/backend/Classes/Controller/UserSettingsController.php+1 −1
- typo3/sysext/backend/Classes/Form/Wizard/ImageManipulationWizard.php+4 −6
- typo3/sysext/backend/Tests/Unit/Controller/Wizard/SuggestWizardControllerTest.php+2 −5
- typo3/sysext/backend/Tests/Unit/Controller/FormInlineAjaxControllerTest.php+9 −19
- typo3/sysext/backend/Tests/Unit/Controller/FormSelectTreeAjaxControllerTest.php+2 −5
- typo3/sysext/beuser/Classes/Controller/PermissionAjaxController.php+4 −5
- typo3/sysext/core/Classes/Controller/FileDumpController.php+3 −3
- typo3/sysext/core/Classes/Imaging/IconFactory.php+4 −8
- typo3/sysext/documentation/Classes/Controller/DocumentController.php+2 −3
- typo3/sysext/frontend/Classes/Controller/ShowImageController.php+5 −6
- typo3/sysext/impexp/Classes/Controller/ImportExportController.php+3 −5
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+3 −4
- typo3/sysext/install/Classes/Controller/BackendModuleController.php+4 −13
- typo3/sysext/lowlevel/Classes/Controller/ConfigurationController.php+3 −4
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+3 −4
- typo3/sysext/opendocs/Classes/Backend/ToolbarItems/OpendocsToolbarItem.php+5 −8
- typo3/sysext/recordlist/Classes/Controller/AbstractLinkBrowserController.php+3 −4
- typo3/sysext/recordlist/Classes/Controller/ElementBrowserController.php+7 −8
- typo3/sysext/recordlist/Classes/Controller/ElementBrowserFramesetController.php+3 −5
- typo3/sysext/recordlist/Classes/RecordList.php+3 −4
- typo3/sysext/recycler/Classes/Controller/RecyclerAjaxController.php+2 −2
- typo3/sysext/rsaauth/Classes/Controller/RsaPublicKeyGenerationController.php+4 −5
- typo3/sysext/rsaauth/Classes/RsaEncryptionEncoder.php+10 −14
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+3 −4
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+3 −5
- typo3/sysext/t3editor/Classes/CodeCompletion.php+6 −16
- typo3/sysext/t3editor/Classes/TypoScriptReferenceLoader.php+1 −1
- typo3/sysext/taskcenter/Classes/Controller/TaskModuleController.php+3 −5
- typo3/sysext/taskcenter/Classes/TaskStatus.php+5 −6
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+3 −4
- typo3/sysext/workspaces/Classes/Controller/AjaxController.php+1 −2
- typo3/sysext/workspaces/Classes/Controller/AjaxDispatcher.php+1 −1
Review log 1525
-
Christian Kuhn uploaded patch set 1 02/16/18, 13:04
-
TYPO3com voted on patch set 1 V -1 02/16/18, 13:04 Completed build in 08s on Fri, 16 Feb, 02:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19703
-
Christian Kuhn uploaded patch set 2 02/16/18, 13:23
-
TYPO3com voted on patch set 2 V +1 02/16/18, 13:31 Completed build in 07m 50s on Fri, 16 Feb, 02:31 PM Test Summary: 30836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19704
-
Christian Kuhn uploaded patch set 3 02/16/18, 14:06
-
TYPO3com voted on patch set 3 V +1 02/16/18, 14:15 Completed build in 08m 20s on Fri, 16 Feb, 03:15 PM Test Summary: 30836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19706
-
Christian Kuhn uploaded patch set 4 02/16/18, 14:38
-
TYPO3com voted on patch set 4 V +1 02/16/18, 14:47 Completed build in 09m 23s on Fri, 16 Feb, 03:47 PM Test Summary: 30836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19710
-
Christian Kuhn uploaded patch set 5 02/16/18, 15:04
-
TYPO3com voted on patch set 5 V +1 02/16/18, 15:16 Completed build in 11m 41s on Fri, 16 Feb, 04:16 PM Test Summary: 30836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19715
-
Christian Kuhn uploaded patch set 6 02/16/18, 15:56
-
TYPO3com voted on patch set 6 V +1 02/16/18, 16:06 Completed build in 09m 34s on Fri, 16 Feb, 05:06 PM Test Summary: 30836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19721
-
Christian Kuhn updated the commit message in patch set 7 02/16/18, 16:13
-
TYPO3com voted on patch set 7 V +1 02/16/18, 16:21 Completed build in 07m 20s on Fri, 16 Feb, 05:21 PM Test Summary: 30836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19724
-
Christian Kuhn uploaded patch set 8 02/16/18, 17:16
-
TYPO3com voted on patch set 8 V -1 02/16/18, 17:17 Completed build in 11s on Fri, 16 Feb, 06:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19727
-
Christian Kuhn uploaded patch set 9 02/16/18, 17:19
-
TYPO3com voted on patch set 9 V -1 02/16/18, 17:27 Completed build in 08m 04s on Fri, 16 Feb, 06:27 PM Test Summary: 1 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19728
-
TYPO3com voted on patch set 9 V +1 02/16/18, 17:29 Completed build in 17m 50s on Fri, 16 Feb, 06:29 PM Test Summary: 30836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19728
-
Mathias Schreiber voted on patch set 9 V +1 CR +1 02/16/18, 17:51
-
Anja Leichsenring voted on patch set 9 V +1 CR +1 02/16/18, 18:54
-
Benjamin Kott voted on patch set 9 V +1 CR +1 02/16/18, 19:02
-
Christian Kuhn voted on patch set 9 V +2 CR +2 02/16/18, 19:04
-
Christian Kuhn merged patch set 10 02/16/18, 19:04
-
Benjamin Franzke commented on patch set 10 02/16/18, 20:15
Unfortunately I am a bit late to the party (post merge): The ajax responses _all_ need to use JsonResponse, not HtmlResponse as the RequestHandler previously added application/json Content-Type by default. eID scripts did not have a default Content-Type header at all. Here's a patch that adresses that: https://review.typo3.org/c/55766/