Review main Merged

55759[FEATURE] Provide VH to render icons for resources

Georg Ringer CR +2 V +2 Normal +146 −16 updated 02/28/18, 12:37

Commit message

Provide a ViewHelper to render the markup to show
an icon for files and folders.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Christian Kuhn +1
  • Verified V +2
    • Frank Nägler +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 3446

Show 1521 earlier messages
  1. Georg Ringer uploaded patch set 1 02/16/18, 18:23

  2. TYPO3com voted on patch set 1 V -1 02/16/18, 18:31 Completed build in 08m 25s on Fri, 16 Feb, 07:31 PM Test Summary: 30836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19730

  3. Georg Ringer uploaded patch set 2 02/16/18, 19:11

  4. TYPO3com voted on patch set 2 V +1 02/16/18, 19:23 Completed build in 12m 15s on Fri, 16 Feb, 08:23 PM Test Summary: 30863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19739

  5. Mathias Schreiber commented on patch set 2 CR -1 02/17/18, 14:39

    can we get a dreprecation rst here?
  6. Georg Ringer uploaded patch set 3 02/19/18, 18:47

  7. Mathias Schreiber voted on patch set 3 V +1 CR +1 02/19/18, 18:53

  8. TYPO3com voted on patch set 3 V +1 02/19/18, 18:58 Completed build in 11m 22s on Mon, 19 Feb, 07:58 PM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19877

  9. Andreas Kienast commented on patch set 3 CR -1 02/19/18, 19:41

    On it
  10. Andreas Kienast uploaded patch set 4 02/19/18, 19:48

  11. Andreas Kienast voted on patch set 4 V +1 CR +1 02/19/18, 19:49

  12. Andreas Kienast uploaded patch set 5 02/19/18, 19:50

  13. Frank Nägler commented on patch set 3 02/19/18, 19:51

    IconForResourceViewHelper.php:28

    I would prefer to add the ressource attribute to the existing IconViewHelper instead of introduce a new ViewHelper.
  14. TYPO3com voted on patch set 4 V +1 02/19/18, 19:58 Completed build in 09m 49s on Mon, 19 Feb, 08:58 PM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19879

  15. TYPO3com voted on patch set 5 V +1 02/19/18, 19:59 Completed build in 08m 48s on Mon, 19 Feb, 08:59 PM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19880

  16. Benni Mack commented on patch set 3 02/20/18, 19:52

    IconForResourceViewHelper.php:28 Reply

    don't know. Actually, we already have a IconForRecord ViewHelper, and the IconForResource is a FAL driven VH, where as the regular "IconViewHelper" does the -nothing-related-to-any-kind-of-record-or-whatever stuff.
  17. Frank Nägler commented on patch set 5 CR +1 02/23/18, 12:45

    I am fine, multiple VH makes the validation easier and cleaner
  18. Frank Nägler commented on patch set 5 V +1 CR -1 02/23/18, 12:50

    after adding the missing alternativeMarkupIdentifier argument I am fine, it work perfect, but the argument should be available for all IconVH

    IconForResourceViewHelper.php:48

    please add the alternativeMarkupIdentifier argument like in the other Icon VH, this setting should be available every time
  19. Georg Ringer uploaded patch set 6 02/23/18, 20:17

  20. TYPO3com voted on patch set 6 V -1 02/23/18, 20:20 Completed build in 02m 34s on Fri, 23 Feb, 09:20 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20080

  21. Jörg Bösche uploaded patch set 7 02/26/18, 08:37

  1. TYPO3com voted on patch set 7 V +1 02/26/18, 08:47 Completed build in 09m 29s on Mon, 26 Feb, 09:47 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20136

  2. Jörg Bösche uploaded patch set 8 02/26/18, 09:14

  3. TYPO3com voted on patch set 8 V +1 02/26/18, 09:22 Completed build in 08m 13s on Mon, 26 Feb, 10:22 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20139

  4. Anja Leichsenring voted on patch set 8 V +1 CR +1 02/26/18, 19:38

  5. Andreas Kienast commented on patch set 8 02/26/18, 19:47

    FileFacade.php:18 Unresolved

    Since you added return type declarations everywhere, do you think it makes sense to add strict_types=1?
  6. Markus Klein updated the commit message in patch set 9 02/26/18, 20:30

  7. TYPO3com voted on patch set 9 V +1 02/26/18, 20:40 Completed build in 09m 30s on Mon, 26 Feb, 09:40 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20177

  8. Markus Klein commented on patch set 10 02/26/18, 20:45

    Published edit on patch set 9.
  9. Markus Klein voted on patch set 10 CR +1 02/26/18, 20:45

  10. TYPO3com voted on patch set 10 V -1 02/26/18, 20:54 Completed build in 09m 06s on Mon, 26 Feb, 09:54 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20178

  11. Markus Klein commented on patch set 11 02/26/18, 22:51

    Published edit on patch set 10.
  12. Markus Klein voted on patch set 11 CR +1 02/26/18, 22:51

  13. TYPO3com voted on patch set 11 V +1 02/26/18, 23:00 Completed build in 08m 41s on Tue, 27 Feb, 12:00 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20185

  14. Stefan Neufeind voted on patch set 11 CR +1 02/27/18, 08:44

  15. Frank Nägler commented on patch set 11 CR -1 02/28/18, 12:14

    FileFacade.php:256

    return could be null
  16. Frank Nägler commented on patch set 11 02/28/18, 12:14

    on it, will fix it
  17. Frank Nägler commented on patch set 11 02/28/18, 12:20

    will push an update for typos

    FileFacade.php:256 Reply

    sry, my mistake, other method....
  18. Frank Nägler uploaded patch set 12 02/28/18, 12:28

  19. Christian Kuhn commented on patch set 11 02/28/18, 12:28

    +1 - however, it is pretty hard to find out if getIcon() is still called by fluid templates. guess we'll have to keep an eye on core deprecation notes to find out.
  20. Christian Kuhn commented on patch set 12 02/28/18, 12:31

    MethodCallMatcher.php:1608

    since getIcon() is a rather common method name, we may trigger lots of false positives here. we'll have to see if we keep that matcher.
  21. Frank Nägler voted on patch set 12 V +1 CR +1 02/28/18, 12:31

  22. Frank Nägler voted on patch set 12 V +2 CR +2 02/28/18, 12:33

  23. Christian Kuhn voted on patch set 12 V +1 CR +1 02/28/18, 12:33

  24. TYPO3com voted on patch set 12 V +1 02/28/18, 12:37 Completed build in 08m 40s on Wed, 28 Feb, 01:37 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20285

  25. Frank Nägler merged patch set 13 02/28/18, 12:37