55759[FEATURE] Provide VH to render icons for resources
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Christian Kuhn +1
-
Verified V +2
- Frank Nägler +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/ViewHelpers/IconForResourceViewHelper.php3new+66 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-83942-DeprecatedFileFacadegetIcon.rstnew+33 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-83942-ProvideViewHelperToRenderIconForResources.rstnew+20 −0
- typo3/sysext/filelist/Classes/FileFacade.php3+19 −15
- typo3/sysext/filelist/Resources/Private/Templates/FileList/Search.html+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php1+7 −0
Review log 3446
Show 1521 earlier messages
-
Georg Ringer uploaded patch set 1 02/16/18, 18:23
-
TYPO3com voted on patch set 1 V -1 02/16/18, 18:31 Completed build in 08m 25s on Fri, 16 Feb, 07:31 PM Test Summary: 30836 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19730
-
Georg Ringer uploaded patch set 2 02/16/18, 19:11
-
TYPO3com voted on patch set 2 V +1 02/16/18, 19:23 Completed build in 12m 15s on Fri, 16 Feb, 08:23 PM Test Summary: 30863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19739
-
Mathias Schreiber commented on patch set 2 CR -1 02/17/18, 14:39
can we get a dreprecation rst here? -
Georg Ringer uploaded patch set 3 02/19/18, 18:47
-
Mathias Schreiber voted on patch set 3 V +1 CR +1 02/19/18, 18:53
-
TYPO3com voted on patch set 3 V +1 02/19/18, 18:58 Completed build in 11m 22s on Mon, 19 Feb, 07:58 PM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19877
-
Andreas Kienast commented on patch set 3 CR -1 02/19/18, 19:41
On it -
Andreas Kienast uploaded patch set 4 02/19/18, 19:48
-
Andreas Kienast voted on patch set 4 V +1 CR +1 02/19/18, 19:49
-
Andreas Kienast uploaded patch set 5 02/19/18, 19:50
-
Frank Nägler commented on patch set 3 02/19/18, 19:51
IconForResourceViewHelper.php:28I would prefer to add the ressource attribute to the existing IconViewHelper instead of introduce a new ViewHelper. -
TYPO3com voted on patch set 4 V +1 02/19/18, 19:58 Completed build in 09m 49s on Mon, 19 Feb, 08:58 PM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19879
-
TYPO3com voted on patch set 5 V +1 02/19/18, 19:59 Completed build in 08m 48s on Mon, 19 Feb, 08:59 PM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19880
-
Benni Mack commented on patch set 3 02/20/18, 19:52
IconForResourceViewHelper.php:28Replydon't know. Actually, we already have a IconForRecord ViewHelper, and the IconForResource is a FAL driven VH, where as the regular "IconViewHelper" does the -nothing-related-to-any-kind-of-record-or-whatever stuff. -
Frank Nägler commented on patch set 5 CR +1 02/23/18, 12:45
I am fine, multiple VH makes the validation easier and cleaner -
Frank Nägler commented on patch set 5 V +1 CR -1 02/23/18, 12:50
after adding the missing alternativeMarkupIdentifier argument I am fine, it work perfect, but the argument should be available for all IconVHIconForResourceViewHelper.php:48please add the alternativeMarkupIdentifier argument like in the other Icon VH, this setting should be available every time -
Georg Ringer uploaded patch set 6 02/23/18, 20:17
-
TYPO3com voted on patch set 6 V -1 02/23/18, 20:20 Completed build in 02m 34s on Fri, 23 Feb, 09:20 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20080
-
Jörg Bösche uploaded patch set 7 02/26/18, 08:37
-
TYPO3com voted on patch set 7 V +1 02/26/18, 08:47 Completed build in 09m 29s on Mon, 26 Feb, 09:47 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20136
-
Jörg Bösche uploaded patch set 8 02/26/18, 09:14
-
TYPO3com voted on patch set 8 V +1 02/26/18, 09:22 Completed build in 08m 13s on Mon, 26 Feb, 10:22 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20139
-
Anja Leichsenring voted on patch set 8 V +1 CR +1 02/26/18, 19:38
-
Andreas Kienast commented on patch set 8 02/26/18, 19:47
FileFacade.php:18UnresolvedSince you added return type declarations everywhere, do you think it makes sense to add strict_types=1? -
Markus Klein updated the commit message in patch set 9 02/26/18, 20:30
-
TYPO3com voted on patch set 9 V +1 02/26/18, 20:40 Completed build in 09m 30s on Mon, 26 Feb, 09:40 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20177
-
Markus Klein commented on patch set 10 02/26/18, 20:45
Published edit on patch set 9. -
Markus Klein voted on patch set 10 CR +1 02/26/18, 20:45
-
TYPO3com voted on patch set 10 V -1 02/26/18, 20:54 Completed build in 09m 06s on Mon, 26 Feb, 09:54 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20178
-
Markus Klein commented on patch set 11 02/26/18, 22:51
Published edit on patch set 10. -
Markus Klein voted on patch set 11 CR +1 02/26/18, 22:51
-
TYPO3com voted on patch set 11 V +1 02/26/18, 23:00 Completed build in 08m 41s on Tue, 27 Feb, 12:00 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20185
-
Stefan Neufeind voted on patch set 11 CR +1 02/27/18, 08:44
-
Frank Nägler commented on patch set 11 CR -1 02/28/18, 12:14
FileFacade.php:256return could be null -
Frank Nägler commented on patch set 11 02/28/18, 12:14
on it, will fix it -
Frank Nägler commented on patch set 11 02/28/18, 12:20
will push an update for typosFileFacade.php:256Replysry, my mistake, other method.... -
Frank Nägler uploaded patch set 12 02/28/18, 12:28
-
Christian Kuhn commented on patch set 11 02/28/18, 12:28
+1 - however, it is pretty hard to find out if getIcon() is still called by fluid templates. guess we'll have to keep an eye on core deprecation notes to find out. -
Christian Kuhn commented on patch set 12 02/28/18, 12:31
MethodCallMatcher.php:1608since getIcon() is a rather common method name, we may trigger lots of false positives here. we'll have to see if we keep that matcher. -
Frank Nägler voted on patch set 12 V +1 CR +1 02/28/18, 12:31
-
Frank Nägler voted on patch set 12 V +2 CR +2 02/28/18, 12:33
-
Christian Kuhn voted on patch set 12 V +1 CR +1 02/28/18, 12:33
-
TYPO3com voted on patch set 12 V +1 02/28/18, 12:37 Completed build in 08m 40s on Wed, 28 Feb, 01:37 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20285
-
Frank Nägler merged patch set 13 02/28/18, 12:37