Review main Merged

55761[BUGFIX] Unit tests call parent::tearDown()

Christian Kuhn CR +2 V +2 Easy +13 −33 updated 02/16/18, 19:05

Commit message

For the memory garbage collection of UnitTestCase to kick in,
it is important that unit tests which implement tearDown()
call parent after their own job.

Fix some missing parent calls, refactor some other tests
slightly to live without tearDown() and activate two tests
that come with an invalid @depends annotation.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 56

  1. Christian Kuhn uploaded patch set 1 02/16/18, 18:27

  2. TYPO3com voted on patch set 1 V +1 02/16/18, 18:38 Completed build in 10m 50s on Fri, 16 Feb, 07:38 PM Test Summary: 30842 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19733

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 02/16/18, 18:49

  4. Mathias Schreiber voted on patch set 1 V +1 CR +1 02/16/18, 19:04

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 02/16/18, 19:05

  6. Christian Kuhn merged patch set 2 02/16/18, 19:05