Review TYPO3_8-7 Merged

55762[BUGFIX] Unit tests call parent::tearDown()

Christian Kuhn CR +2 V +2 Easy +13 −28 updated 02/16/18, 19:05

Commit message

For the memory garbage collection of UnitTestCase to kick in,
it is important that unit tests which implement tearDown()
call parent after their own job.

Fix some missing parent calls, refactor some other tests
slightly to live without tearDown() and activate two tests
that come with an invalid @depends annotation.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 46

  1. Christian Kuhn uploaded patch set 1 02/16/18, 18:41

  2. TYPO3com voted on patch set 1 V -1 02/16/18, 18:41 Completed build in 08s on Fri, 16 Feb, 07:41 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1858

  3. Christian Kuhn uploaded patch set 2 02/16/18, 18:46

  4. TYPO3com voted on patch set 2 V +1 02/16/18, 19:00 Completed build in 13m 36s on Fri, 16 Feb, 08:00 PM Test Summary: 58111 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1859

  5. Christian Kuhn voted on patch set 2 V +2 CR +2 02/16/18, 19:05

  6. Christian Kuhn merged patch set 3 02/16/18, 19:05