Review main Merged

55763[TASK] Remove ErrorIconViewHelper and move logic into model and template

Georg Ringer CR +2 V +2 Normal +21 −73 updated 02/19/18, 19:51

Commit message

Simplify generation of the error icon by removing the ViewHelper and
generate the icon identifier in the model instead.

As the ViewHelper is no public API it can be removed without a RST file.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1015

  1. Georg Ringer uploaded patch set 1 02/16/18, 18:55

  2. TYPO3com voted on patch set 1 V -1 02/16/18, 19:04 Completed build in 09m 02s on Fri, 16 Feb, 08:04 PM Test Summary: 2 of 30993 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19735

  3. Georg Ringer rebased onto patch set 2 02/16/18, 19:07

  4. TYPO3com voted on patch set 2 V -1 02/16/18, 19:22 Completed build in 14m 47s on Fri, 16 Feb, 08:22 PM Test Summary: 1 of 31014 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19738

  5. Georg Ringer rebased onto patch set 3 02/17/18, 07:14

  6. TYPO3com voted on patch set 3 V +1 02/17/18, 07:22 Completed build in 07m 33s on Sat, 17 Feb, 08:22 AM Test Summary: 30863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19760

  7. Mathias Schreiber commented on patch set 3 CR -1 02/17/18, 14:45

    LogEntry.php:295 Unresolved

    this one needs to be empty-empty
  8. Benni Mack commented on patch set 4 02/19/18, 08:43

    Published edit on patch set 3.
  9. TYPO3com voted on patch set 4 V -1 02/19/18, 08:52 Completed build in 08m 28s on Mon, 19 Feb, 09:52 AM Test Summary: 1 of 31054 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19843

  10. Georg Ringer rebased onto patch set 5 02/19/18, 10:16

  11. TYPO3com voted on patch set 5 V +1 02/19/18, 10:25 Completed build in 08m 59s on Mon, 19 Feb, 11:25 AM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19851

  12. Andreas Kienast voted on patch set 5 CR +1 02/19/18, 12:41

  13. Andreas Kienast voted on patch set 5 V +1 02/19/18, 18:03

  14. Wouter Wolters voted on patch set 5 V +2 CR +2 02/19/18, 19:51

  15. Wouter Wolters merged patch set 6 02/19/18, 19:51