Review main Merged

55766[BUGFIX] Use correct content types in backend ajax and eID responses

Benjamin Franzke CR +2 V +2 Normal +38 −32 updated 02/17/18, 19:30

Commit message

Due to the recent changes in the commit:
    e487cf526980570aa8f7a92d170bf439637c5972
    [TASK] Create own response instance in controller actions

..ajax routes and eID handlers that used a *pre-generated* Response
object (from the RequestHandler) now return different Content-Type
headers than before.

For backend ajax request applicaton/json was set by default,
for eID scripts no Content-Type was set (by default).

Change these controllers to use JsonResponse or a plain Response
to reflect the previous state..

The changes in this commit were intended to be squashed into the
mentioned commit – but this commit was too late. Therefore other (a bit)
unrelated optimizations to changes that patch made are included.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 13

Review log 1419

  1. Benjamin Franzke uploaded patch set 1 02/16/18, 20:12

  2. Benjamin Franzke updated the commit message in patch set 2 02/16/18, 20:19

  3. TYPO3com voted on patch set 1 V -1 02/16/18, 20:23 Completed build in 10m 54s on Fri, 16 Feb, 09:23 PM Test Summary: 4 of 31014 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19748

  4. TYPO3com voted on patch set 2 V -1 02/16/18, 20:28 Completed build in 08m 39s on Fri, 16 Feb, 09:28 PM Test Summary: 5 of 31014 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19750

  5. Benjamin Franzke rebased onto patch set 3 02/16/18, 20:31

  6. TYPO3com voted on patch set 3 V -1 02/16/18, 20:41 Completed build in 10m 00s on Fri, 16 Feb, 09:41 PM Test Summary: 3 of 31014 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19752

  7. Benjamin Franzke commented on patch set 3 CR -1 02/16/18, 20:59

    We can not pass a string to JsonResponse. Working on it.
  8. Benjamin Franzke uploaded patch set 4 02/16/18, 21:12

  9. TYPO3com voted on patch set 4 V -1 02/16/18, 21:12 Completed build in 09s on Fri, 16 Feb, 10:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19755

  10. Benjamin Franzke uploaded patch set 5 02/16/18, 21:36

  11. TYPO3com voted on patch set 5 V +1 02/16/18, 21:44 Completed build in 08m 19s on Fri, 16 Feb, 10:44 PM Test Summary: 30863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19757

  12. Christian Kuhn voted on patch set 5 CR -1 02/16/18, 22:26

  13. Christian Kuhn voted on patch set 5 CR +1 02/16/18, 22:26

  14. Christian Kuhn voted on patch set 5 V +1 02/17/18, 09:07

  15. Anja Leichsenring voted on patch set 5 V +1 CR +1 02/17/18, 12:36

  16. Mathias Schreiber commented on patch set 5 02/17/18, 18:43

    ShowImageController.php:203

    what's the benefit here? (still learning)
  17. Christian Kuhn commented on patch set 5 02/17/18, 19:30

    ShowImageController.php:203 Reply Unresolved

    none. that reconstitutes the exact behavior before my patch, eid has sent slightly different headers, the patch takes care these are the same as before.
  18. Christian Kuhn voted on patch set 5 V +2 CR +2 02/17/18, 19:30

  19. Christian Kuhn merged patch set 6 02/17/18, 19:30