Review main Merged

55771[TASK] Add UnitTest for Compatibility7ExtractionUpdate

Anja Leichsenring CR +2 V +2 Normal +128 −0 updated 02/17/18, 19:25

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1115

  1. Anja Leichsenring uploaded patch set 1 02/17/18, 12:24

  2. TYPO3com voted on patch set 1 V -1 02/17/18, 12:34 Completed build in 10m 23s on Sat, 17 Feb, 01:34 PM Test Summary: 340 of 31029 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19765

  3. Anja Leichsenring updated the commit message in patch set 2 02/17/18, 15:44

  4. TYPO3com voted on patch set 2 V -1 02/17/18, 15:53 Completed build in 09m 13s on Sat, 17 Feb, 04:53 PM Test Summary: 418 of 31029 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19778

  5. Anja Leichsenring uploaded patch set 3 02/17/18, 16:19

  6. TYPO3com voted on patch set 3 V +1 02/17/18, 16:28 Completed build in 08m 13s on Sat, 17 Feb, 05:28 PM Test Summary: 30878 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19779

  7. Andreas Kienast uploaded patch set 4 02/17/18, 16:37

  8. TYPO3com voted on patch set 4 V +1 02/17/18, 16:45 Completed build in 07m 37s on Sat, 17 Feb, 05:45 PM Test Summary: 30878 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19780

  9. Andreas Kienast voted on patch set 4 V +1 CR +1 02/17/18, 16:47

  10. Mathias Schreiber commented on patch set 4 02/17/18, 18:37

    Compatibility7ExtractionUpdateTest.php:83

    does this break CLI usage?
  11. Christian Kuhn commented on patch set 4 02/17/18, 19:00

    Compatibility7ExtractionUpdateTest.php:83 Reply Unresolved

    that would be an issue of $subject, then.
  12. Christian Kuhn voted on patch set 4 V +2 CR +2 02/17/18, 19:00

  13. Christian Kuhn merged patch set 5 02/17/18, 19:00

  14. Christian Kuhn commented on patch set 5 02/17/18, 19:01

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit f8440061d72adf19e4a095fc743a80c6e119ddcd
  15. Christian Kuhn commented on patch set 5 02/17/18, 19:25

    skipped the backport.