Review TYPO3_4-5 Merged

5579[BUGFIX] EM, Error when downloading extension files

Markus Klein CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Trying to download a file using the Edit Files page of the old EM
leads to a fatal error, because URL is not decoded properly.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Steffen Gebert +2
    • Stefan +1
  • Verified V +2
    • Xavier Perseguers +2
    • Steffen Gebert +2
    • Stefan +1

Issues 1

Files 1

Review log 6

  1. Xavier Perseguers commented on patch set 1 V 0 10/07/11, 17:31

    by team member; Looks good to me, approved
  2. Steffen Gebert commented on patch set 1 V 0 10/07/11, 17:31

    by team member; Looks good to me, approved
  3. Philipp Gampe commented on patch set 1 10/07/11, 17:31

    If the change is the same in both branches, please upload to master only. The pusher should take care of submitting to older branches and to push it there without additional review. This keeps the review queue clean.
  4. Mr. Jenkins commented on patch set 1 10/07/11, 17:31

  5. Stefan commented on patch set 1 10/07/11, 17:31

    Verified; Looks good to me, but someone else must approve patch tested on 4.5.6 on Debian 5.x code reviewed
  6. Steffen Gebert merged patch set 1 10/07/11, 17:31