Review TYPO3_8-7 Merged

55810[TASK] Extend untangleFilesArray function test in RequestBuilder

Stefan Neufeind CR +2 V +2 Easy +26 −0 updated 02/20/18, 10:58

Commit message

Check for cases where the files array is nested more complex or
keywords (e.g. "error") are used as field names.

Run `curl -F "d0[]=@d12.txt" -F "d0[d1][d2][d3]=@d12.txt"
-F "error=@error_file.txt" localhost:8080` against a custom
php script to generate the testing $_FILES array.

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
  • Verified V +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Stefan Neufeind commented on patch set 1 02/20/18, 03:40

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/20/18, 03:55 Completed build in 14m 24s on Tue, 20 Feb, 04:55 AM Test Summary: 58113 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1899

  3. Stefan Neufeind commented on patch set 1 V +1 CR +1 02/20/18, 04:07

    straight cherrypick. Bamboo ran the functional tests for us - so I guess we can assume that's okay then?
  4. Benni Mack voted on patch set 1 V +2 CR +2 02/20/18, 10:58

  5. Benni Mack merged patch set 2 02/20/18, 10:58