Review main Merged

55824[BUGFIX] Move file extension detection to FAL driver

Frans Saris CR +2 V +2 Normal +60 −8 updated 04/16/18, 20:40

Commit message

The only object that is allowed to handle the physical file in the FAL
is the driver. As that's the only instance that knows how to access the
file.

This patch makes sure the Indexer and FileExtensionFilter asks the
driver of the file extension instead of using the PathUtility itself.

Review

  • Code review CR +2
    • Markus Klein +2
    • Anja Leichsenring +1
    • Richard Haeser +1
    • Nicole Hummel +1
  • Verified V +2
    • Markus Klein +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 3549

Show 1424 earlier messages
  1. Frans Saris uploaded patch set 1 02/20/18, 13:36

  2. TYPO3com voted on patch set 1 V +1 02/20/18, 13:44 Completed build in 07m 32s on Tue, 20 Feb, 02:44 PM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19908

  3. Frans Saris uploaded patch set 2 02/21/18, 09:14

  4. TYPO3com voted on patch set 2 V -1 02/21/18, 09:22 Completed build in 07m 26s on Wed, 21 Feb, 10:22 AM Test Summary: 14 of 31059 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19963

  5. TYPO3com commented on patch set 2 02/21/18, 13:33 Completed build in 4h 26m 43s on Wed, 21 Feb, 02:33 PM Test Summary: 14 of 31059 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19963

  6. Frans Saris rebased onto patch set 3 02/21/18, 13:56

  7. TYPO3com voted on patch set 3 V -1 02/21/18, 14:05 Completed build in 09m 20s on Wed, 21 Feb, 03:05 PM Test Summary: 14 of 31059 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19973

  8. Anja Leichsenring uploaded patch set 4 04/14/18, 15:17

  9. TYPO3com voted on patch set 4 V -1 04/14/18, 15:26 Completed build in 08m 48s on Sat, 14 Apr, 05:26 PM Test Summary: 14 of 31102 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22327

  10. Anja Leichsenring uploaded patch set 5 04/14/18, 15:30

  11. TYPO3com voted on patch set 5 V -1 04/14/18, 15:30 Completed build in 10s on Sat, 14 Apr, 05:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22328

  12. Anja Leichsenring uploaded patch set 6 04/14/18, 15:31

  13. Anja Leichsenring uploaded patch set 7 04/14/18, 15:36

  14. Anja Leichsenring commented on patch set 7 V +1 CR +1 04/14/18, 15:40

    rebased, and fixed the tests
  15. TYPO3com voted on patch set 6 V -1 04/14/18, 15:40 Completed build in 08m 58s on Sat, 14 Apr, 05:40 PM Test Summary: 2 of 31102 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22329

  16. TYPO3com voted on patch set 7 V +1 04/14/18, 15:44 Completed build in 08m 06s on Sat, 14 Apr, 05:44 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22330

  17. Frans Saris uploaded patch set 8 04/15/18, 09:25

  18. Frans Saris commented on patch set 8 04/15/18, 09:26

    tnx Anja for updating this patch. I just added the rst file to make it complete.
  19. TYPO3com voted on patch set 8 V +1 04/15/18, 09:35 Completed build in 09m 30s on Sun, 15 Apr, 11:35 AM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22351

  20. Benni Mack voted on patch set 8 CR +1 04/15/18, 10:50

  21. Benni Mack updated the commit message in patch set 9 04/15/18, 10:50

  22. Benni Mack voted on patch set 9 CR +1 04/15/18, 10:50

  23. Wouter Wolters commented on patch set 9 CR -1 04/15/18, 10:56

    Deprecation-83976-MovedFileExtensionDetectionToFALDriver.rst:12

    this sentence is wrong. thatThe
  24. TYPO3com voted on patch set 9 V +1 04/15/18, 11:01 Completed build in 10m 43s on Sun, 15 Apr, 01:01 PM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22360

  1. Frans Saris commented on patch set 10 04/15/18, 17:35

    Published edit on patch set 9.
  2. Frans Saris commented on patch set 9 04/15/18, 17:35

    Deprecation-83976-MovedFileExtensionDetectionToFALDriver.rst:12 Reply

    Done
  3. TYPO3com voted on patch set 10 V +1 04/15/18, 17:43 Completed build in 08m 13s on Sun, 15 Apr, 07:43 PM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22371

  4. Anja Leichsenring voted on patch set 10 V +1 CR +1 04/16/18, 05:32

  5. Andreas Kienast commented on patch set 10 CR -1 04/16/18, 05:42

    FileExtensionFilter.php:106 Unresolved

    9.2 is already released
  6. Frans Saris commented on patch set 10 CR -1 04/16/18, 06:21

    on it
  7. Frans Saris commented on patch set 11 04/16/18, 06:22

    Published edit on patch set 10.
  8. TYPO3com voted on patch set 11 V +1 04/16/18, 06:31 Completed build in 09m 00s on Mon, 16 Apr, 08:31 AM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22375

  9. Andreas Kienast voted on patch set 11 CR +1 04/16/18, 07:18

  10. Benni Mack updated the commit message in patch set 12 04/16/18, 08:32

  11. Benni Mack voted on patch set 12 CR +1 04/16/18, 08:32

  12. TYPO3com voted on patch set 12 V +1 04/16/18, 08:40 Completed build in 08m 05s on Mon, 16 Apr, 10:40 AM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22384

  13. Mathias Schreiber voted on patch set 12 V +1 CR +1 04/16/18, 14:01

  14. Nicole Hummel commented on patch set 12 04/16/18, 15:52

    FileExtensionFilter.php:102

    Which exception is expected here?

    FileExtensionFilter.php:107

    missing strtolower?

    Deprecation-83976-MovedFileExtensionDetectionToFALDriver.rst:11

    superfluous spaces at line ending
  15. Markus Klein commented on patch set 12 04/16/18, 15:56

    Deprecation-83976-MovedFileExtensionDetectionToFALDriver.rst:29

    3rd
  16. Frans Saris commented on patch set 12 CR -1 04/16/18, 17:05

    on it
  17. Frans Saris uploaded patch set 13 04/16/18, 17:14

  18. Frans Saris commented on patch set 12 04/16/18, 17:16

    FileExtensionFilter.php:102 Reply

    Done

    FileExtensionFilter.php:107 Reply

    moved it back to `isAllowed()` to be sure is't always lowercase

    Deprecation-83976-MovedFileExtensionDetectionToFALDriver.rst:11 Reply

    Done

    Deprecation-83976-MovedFileExtensionDetectionToFALDriver.rst:29 Reply

    Done
  19. TYPO3com voted on patch set 13 V +1 04/16/18, 17:24 Completed build in 09m 57s on Mon, 16 Apr, 07:24 PM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22428

  20. Richard Haeser voted on patch set 13 CR +1 04/16/18, 17:40

  21. Nicole Hummel voted on patch set 13 CR +1 04/16/18, 18:42

  22. Anja Leichsenring voted on patch set 13 V +1 CR +1 04/16/18, 20:04

  23. Markus Klein commented on patch set 13 CR +1 04/16/18, 20:36

    testing
  24. Markus Klein voted on patch set 13 V +2 CR +2 04/16/18, 20:38

  25. Markus Klein merged patch set 14 04/16/18, 20:40