55824[BUGFIX] Move file extension detection to FAL driver
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Anja Leichsenring +1
- Richard Haeser +1
- Nicole Hummel +1
-
Verified V +2
- Markus Klein +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+3 −1
- typo3/sysext/core/Classes/Resource/Filter/FileExtensionFilter.php5+15 −5
- typo3/sysext/core/Classes/Resource/Index/Indexer.php+4 −1
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-83976-MovedFileExtensionDetectionToFALDriver.rst6new+37 −0
- typo3/sysext/core/Tests/Unit/Resource/Utility/FileExtensionFilterTest.php+1 −1
Review log 3549
Show 1424 earlier messages
-
Frans Saris uploaded patch set 1 02/20/18, 13:36
-
TYPO3com voted on patch set 1 V +1 02/20/18, 13:44 Completed build in 07m 32s on Tue, 20 Feb, 02:44 PM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19908
-
Frans Saris uploaded patch set 2 02/21/18, 09:14
-
TYPO3com voted on patch set 2 V -1 02/21/18, 09:22 Completed build in 07m 26s on Wed, 21 Feb, 10:22 AM Test Summary: 14 of 31059 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19963
-
TYPO3com commented on patch set 2 02/21/18, 13:33 Completed build in 4h 26m 43s on Wed, 21 Feb, 02:33 PM Test Summary: 14 of 31059 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19963
-
Frans Saris rebased onto patch set 3 02/21/18, 13:56
-
TYPO3com voted on patch set 3 V -1 02/21/18, 14:05 Completed build in 09m 20s on Wed, 21 Feb, 03:05 PM Test Summary: 14 of 31059 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19973
-
Anja Leichsenring uploaded patch set 4 04/14/18, 15:17
-
TYPO3com voted on patch set 4 V -1 04/14/18, 15:26 Completed build in 08m 48s on Sat, 14 Apr, 05:26 PM Test Summary: 14 of 31102 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22327
-
Anja Leichsenring uploaded patch set 5 04/14/18, 15:30
-
TYPO3com voted on patch set 5 V -1 04/14/18, 15:30 Completed build in 10s on Sat, 14 Apr, 05:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22328
-
Anja Leichsenring uploaded patch set 6 04/14/18, 15:31
-
Anja Leichsenring uploaded patch set 7 04/14/18, 15:36
-
Anja Leichsenring commented on patch set 7 V +1 CR +1 04/14/18, 15:40
rebased, and fixed the tests -
TYPO3com voted on patch set 6 V -1 04/14/18, 15:40 Completed build in 08m 58s on Sat, 14 Apr, 05:40 PM Test Summary: 2 of 31102 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22329
-
TYPO3com voted on patch set 7 V +1 04/14/18, 15:44 Completed build in 08m 06s on Sat, 14 Apr, 05:44 PM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22330
-
Frans Saris uploaded patch set 8 04/15/18, 09:25
-
Frans Saris commented on patch set 8 04/15/18, 09:26
tnx Anja for updating this patch. I just added the rst file to make it complete. -
TYPO3com voted on patch set 8 V +1 04/15/18, 09:35 Completed build in 09m 30s on Sun, 15 Apr, 11:35 AM Test Summary: 30948 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22351
-
Benni Mack voted on patch set 8 CR +1 04/15/18, 10:50
-
Benni Mack updated the commit message in patch set 9 04/15/18, 10:50
-
Benni Mack voted on patch set 9 CR +1 04/15/18, 10:50
-
Wouter Wolters commented on patch set 9 CR -1 04/15/18, 10:56
Deprecation-83976-MovedFileExtensionDetectionToFALDriver.rst:12this sentence is wrong. thatThe -
TYPO3com voted on patch set 9 V +1 04/15/18, 11:01 Completed build in 10m 43s on Sun, 15 Apr, 01:01 PM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22360
-
Frans Saris commented on patch set 10 04/15/18, 17:35
Published edit on patch set 9. -
Frans Saris commented on patch set 9 04/15/18, 17:35
Deprecation-83976-MovedFileExtensionDetectionToFALDriver.rst:12ReplyDone -
TYPO3com voted on patch set 10 V +1 04/15/18, 17:43 Completed build in 08m 13s on Sun, 15 Apr, 07:43 PM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22371
-
Anja Leichsenring voted on patch set 10 V +1 CR +1 04/16/18, 05:32
-
Andreas Kienast commented on patch set 10 CR -1 04/16/18, 05:42
FileExtensionFilter.php:106Unresolved9.2 is already released -
Frans Saris commented on patch set 10 CR -1 04/16/18, 06:21
on it -
Frans Saris commented on patch set 11 04/16/18, 06:22
Published edit on patch set 10. -
TYPO3com voted on patch set 11 V +1 04/16/18, 06:31 Completed build in 09m 00s on Mon, 16 Apr, 08:31 AM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22375
-
Andreas Kienast voted on patch set 11 CR +1 04/16/18, 07:18
-
Benni Mack updated the commit message in patch set 12 04/16/18, 08:32
-
Benni Mack voted on patch set 12 CR +1 04/16/18, 08:32
-
TYPO3com voted on patch set 12 V +1 04/16/18, 08:40 Completed build in 08m 05s on Mon, 16 Apr, 10:40 AM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22384
-
Mathias Schreiber voted on patch set 12 V +1 CR +1 04/16/18, 14:01
-
Nicole Hummel commented on patch set 12 04/16/18, 15:52
FileExtensionFilter.php:102Which exception is expected here?FileExtensionFilter.php:107missing strtolower?Deprecation-83976-MovedFileExtensionDetectionToFALDriver.rst:11superfluous spaces at line ending -
Markus Klein commented on patch set 12 04/16/18, 15:56
Deprecation-83976-MovedFileExtensionDetectionToFALDriver.rst:293rd -
Frans Saris commented on patch set 12 CR -1 04/16/18, 17:05
on it -
Frans Saris uploaded patch set 13 04/16/18, 17:14
-
Frans Saris commented on patch set 12 04/16/18, 17:16
FileExtensionFilter.php:102ReplyDoneFileExtensionFilter.php:107Replymoved it back to `isAllowed()` to be sure is't always lowercaseDeprecation-83976-MovedFileExtensionDetectionToFALDriver.rst:11ReplyDoneDeprecation-83976-MovedFileExtensionDetectionToFALDriver.rst:29ReplyDone -
TYPO3com voted on patch set 13 V +1 04/16/18, 17:24 Completed build in 09m 57s on Mon, 16 Apr, 07:24 PM Test Summary: 30950 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-22428
-
Richard Haeser voted on patch set 13 CR +1 04/16/18, 17:40
-
Nicole Hummel voted on patch set 13 CR +1 04/16/18, 18:42
-
Anja Leichsenring voted on patch set 13 V +1 CR +1 04/16/18, 20:04
-
Markus Klein commented on patch set 13 CR +1 04/16/18, 20:36
testing -
Markus Klein voted on patch set 13 V +2 CR +2 04/16/18, 20:38
-
Markus Klein merged patch set 14 04/16/18, 20:40