Review main Merged

55832[BUGFIX] EXT:form - fix design glitches of new element modal

Andreas Steiger CR +2 V +2 Easy +2 −4 updated 02/20/18, 17:40

Commit message

Streamline the markup of the new element modal of the form editor and
fix some style glitches due to side effects with other extensions.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Björn Jacob +1
  • Verified V +2
    • Oliver Hader +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 916

  1. Andreas Steiger uploaded patch set 1 02/20/18, 16:20

  2. TYPO3com voted on patch set 1 V -1 02/20/18, 16:31 Completed build in 11m 09s on Tue, 20 Feb, 05:31 PM Test Summary: 1 of 31054 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19917

  3. TYPO3com commented on patch set 1 02/20/18, 16:37 Completed build in 28m 35s on Tue, 20 Feb, 05:37 PM Test Summary: 26 of 31054 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19917

  4. TYPO3com voted on patch set 1 V +1 02/20/18, 16:39 Completed build in 47m 33s on Tue, 20 Feb, 05:39 PM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19917

  5. TYPO3com commented on patch set 1 02/20/18, 16:51 Completed build in 59m 49s on Tue, 20 Feb, 05:51 PM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19917

  6. Oliver Hader updated the commit message in patch set 2 02/20/18, 17:07

  7. Oliver Hader updated the commit message in patch set 3 02/20/18, 17:08

  8. Björn Jacob updated the commit message in patch set 4 02/20/18, 17:15

  9. Björn Jacob voted on patch set 4 V +1 CR +1 02/20/18, 17:15

  10. TYPO3com voted on patch set 2 V -1 02/20/18, 17:19 Completed build in 11m 27s on Tue, 20 Feb, 06:19 PM Test Summary: 26 of 31054 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19926

  11. Oliver Hader voted on patch set 4 V +1 CR +1 02/20/18, 17:20

  12. Oliver Hader commented on patch set 4 02/20/18, 17:21

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 4be7801bf6e582d4902f2ae8f99aade4d3d219dd
  13. TYPO3com voted on patch set 3 V +1 02/20/18, 17:21 Completed build in 12m 46s on Tue, 20 Feb, 06:21 PM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19927

  14. TYPO3com voted on patch set 4 V +1 02/20/18, 17:27 Completed build in 12m 35s on Tue, 20 Feb, 06:27 PM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19930

  15. Oliver Hader voted on patch set 4 V +2 CR +2 02/20/18, 17:40

  16. Oliver Hader merged patch set 5 02/20/18, 17:40