55833[BUGFIX] Catch all exceptions in page module of form framework
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Mathias Schreiber +1
- Sascha Egerer +1
-
Verified V +2
- Christian Kuhn +2
- Mathias Schreiber +1
- Sascha Egerer +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1420
-
Ralf Zimmermann uploaded patch set 1 02/20/18, 16:40
-
TYPO3com voted on patch set 1 V +1 02/20/18, 16:52 Completed build in 12m 01s on Tue, 20 Feb, 05:52 PM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19922
-
Björn Jacob updated the commit message in patch set 2 02/20/18, 17:17
-
TYPO3com voted on patch set 2 V -1 02/20/18, 17:31 Completed build in 14m 12s on Tue, 20 Feb, 06:31 PM Test Summary: 26 of 31054 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19931
-
Oliver Hader updated the commit message in patch set 3 02/20/18, 18:08
-
TYPO3com voted on patch set 3 V -1 02/20/18, 18:23 Completed build in 15m 04s on Tue, 20 Feb, 07:23 PM Test Summary: 1 of 31054 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19940
-
TYPO3com commented on patch set 3 02/20/18, 18:26 Completed build in 33m 43s on Tue, 20 Feb, 07:26 PM Test Summary: 1 of 31054 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19940
-
TYPO3com voted on patch set 3 V +1 02/20/18, 18:29 Completed build in 54m 46s on Tue, 20 Feb, 07:29 PM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19940
-
Mathias Schreiber commented on patch set 3 02/20/18, 18:46
-
Oliver Hader commented on patch set 3 CR +1 02/21/18, 10:40
YamlSource.php:77Reply UnresolvedLocalizing the exception message happens in the PreviewRenderer which where low-level processing is prepared for representation in UI. Localization directly in low-level components - like YamlSource - should not be implemented since that would extend the component dependencies to dynamic user-specific context. -
Mathias Schreiber voted on patch set 3 V +1 CR +1 03/07/18, 17:49
-
Christian Kuhn commented on patch set 3 03/07/18, 22:31
FormPagePreviewRenderer.php:101a small comment could be great here, so we have a chance to change that to more specific catch as soon as FAL is fixed and throws more specific exceptions. -
Christian Kuhn uploaded patch set 4 03/07/18, 23:21
-
Christian Kuhn voted on patch set 4 V +1 CR +1 03/07/18, 23:21
-
TYPO3com voted on patch set 4 V +1 03/07/18, 23:29 Completed build in 08m 22s on Thu, 8 Mar, 12:29 AM Test Summary: 30819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20661
-
Mathias Schreiber voted on patch set 4 V +1 CR +1 03/08/18, 08:15
-
Sascha Egerer voted on patch set 4 V +1 CR +1 03/08/18, 10:19
-
Christian Kuhn voted on patch set 4 V +2 CR +2 03/08/18, 10:44
-
Christian Kuhn merged patch set 5 03/08/18, 10:44
-
Christian Kuhn commented on patch set 5 03/08/18, 10:44
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit a91a984b60e9d390ccf88f069a1b3bfa0539f05b
YamlSource.php:77